Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp131696pxj; Tue, 15 Jun 2021 22:04:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzC41edY+6ccwwFUHzdkMUIJeEwVnvLADH6xpn66xdPDJhb4FhJ0GsMWEZKNYjWrK1+t1Rd X-Received: by 2002:a05:6402:22fa:: with SMTP id dn26mr1842104edb.230.1623819877080; Tue, 15 Jun 2021 22:04:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623819877; cv=none; d=google.com; s=arc-20160816; b=UeW/SqdheWcD5TOOttXbi02tfPNVM/JAOYf7RbYSt4hpxRxIw+AiuOR/Utl3NbTO/H A/1pHXYXF5Q0vb9v5PfCYyS55S/aa89QqSQdEnIWbbeNU++iEhGBngWnYptZgAEmCpm+ oy+ZyZBeZeLDPDasqD2j+4j3oDFm2hDmbYCG4b3y/JzoMSL1MuFyBRKVW6CFJR/5Ikaw poQTe+fBOVBkcNd9rKtJRGorgUnqKB1OWGJzmO9FKN4YGGxqAfAXmCrFOZyQO4NRkkfW Z1k9cwkNP6mKc8pzVsjJT1fevXszOLqX8N86cVNM41DmY6L93NbxX7WZ2tEn+pkQoFtv X5HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=MN/vs/tG0hq5jwafeH0YbgqH5zzJ72WpoCmMYfNlszc=; b=VtsPu/jVLflQSpQwVUWTBSuxph5xYvzFD7mWkxQBbpL0+KijmS8/g+wR7ngULVkRi1 fmrVY71sGPqZ/OUNupXTyoSb+qLoVNs7JFL1LwbPLK3NsynYdRldRcrzEtyNYgVl7cIx +NbCnQ4yO20c6akA/IcU9+aYOCrIGkhZHyS57bSjA7pAbxqDarkxREjgBk94KAvBcOVc xKlNnCucBMaMW2pZwknl0fAfxVY6FY+AVuPVpniecyWkgqiWDhSeK3w3cc/biRTQ8oYJ RolvCRDGD/8derKG4U8KZW+Kaw3pz7lo5dJAKhGQle3wyAuDLlthgDKkDO5KIGWIXqdZ +03g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f8si919380edr.154.2021.06.15.22.04.14; Tue, 15 Jun 2021 22:04:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230508AbhFPFCu (ORCPT + 99 others); Wed, 16 Jun 2021 01:02:50 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:48336 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229559AbhFPFCt (ORCPT ); Wed, 16 Jun 2021 01:02:49 -0400 Received: from localhost.localdomain ([86.243.172.93]) by mwinf5d01 with ME id Hh0e2500E21Fzsu03h0f1C; Wed, 16 Jun 2021 07:00:42 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Wed, 16 Jun 2021 07:00:42 +0200 X-ME-IP: 86.243.172.93 From: Christophe JAILLET To: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org, alexander.h.duyck@intel.com, jeffrey.t.kirsher@intel.com Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] fm10k: : Fix an error handling path in 'fm10k_probe()' Date: Wed, 16 Jun 2021 07:00:36 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: 19ae1b3fb99c ("fm10k: Add support for PCI power management and error handling") Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c index dbcae92bb18d..adfa2768f024 100644 --- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c +++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c @@ -2227,6 +2227,7 @@ static int fm10k_probe(struct pci_dev *pdev, const struct pci_device_id *ent) err_ioremap: free_netdev(netdev); err_alloc_netdev: + pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma: -- 2.30.2