Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp132999pxj; Tue, 15 Jun 2021 22:06:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmPKozcS71rwwbk1/h9hVW+yr2+taHgtCcPb8mv4dLr8ntUMfE1OohMghIBvb1zxfC53xI X-Received: by 2002:a05:6e02:1ca8:: with SMTP id x8mr2263662ill.163.1623820006041; Tue, 15 Jun 2021 22:06:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623820006; cv=none; d=google.com; s=arc-20160816; b=aytggPOL20hUExbDalnj4xdapTVobTldwGcv+eUhj7SRk05d4XkJegWMCRey9Z1pDD yGz1JnMHcUVdhcuAKJf0pdlPxnRlQhqPLGA3+mpwVtnJLXFTkOcStbRU/Qloe0F6sGhm JxaLe9SRr6UJDIYjgvUic5lzLWXS3lMzCSvpJDo/UGWHPvG+M9MXHiWcYyr36UHscJSI 4IS/YxuB5q8MahV3ZML4p48n1zivhdUhA/PMHvPnE2pXBS1Xwx5wmFBo7Zcvt+RV/Y8v 2q5zLhs9pd1ykeK8bxuip00RaeYM09NLwD95IqxX8cTJKrAxmXkHmPwM1od9eSNMKO0e //kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=de61f3GXc/N2HodwoG9MKZAUNH0+1i+ZYabn/6ZjHsc=; b=I7tvMKeDZ5d1DanbO2+qE4PgvKO8bCprlF3v2YOrSxJJz5VL32+VQVwqxIXYsOECos JlOtpjpQqoAkgPmmfdxJXKY05PLNtHe7ECPPGMvAmEHULUv4Or4//t32QXjOGsfS/pwG t/kYEHSHa9FPGf0fX3e0UJdSq3hWVj09FtA8sAfp50DJuokrNPPqKF5oMeENQraVotr4 M4znYQhjUaLfkHZfJ7mQxiVsA98RnmJAIiJAC6ebMHZ3R2AlDGDy2H0CcnSEs8+171pp Th6snXLcc+N46Bv4zvJqKrHjhuJvZ2koHDLWdm+ngTscMqZqwk3nUSgMo/sHRz9yfXsZ AZTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f6si951786iox.103.2021.06.15.22.06.32; Tue, 15 Jun 2021 22:06:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230473AbhFPFID (ORCPT + 99 others); Wed, 16 Jun 2021 01:08:03 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:60813 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230084AbhFPFIC (ORCPT ); Wed, 16 Jun 2021 01:08:02 -0400 Received: from localhost.localdomain ([86.243.172.93]) by mwinf5d01 with ME id Hh5v2500321Fzsu03h5vLM; Wed, 16 Jun 2021 07:05:56 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Wed, 16 Jun 2021 07:05:56 +0200 X-ME-IP: 86.243.172.93 From: Christophe JAILLET To: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org, jeffrey.t.kirsher@intel.com Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] e1000e: Fix an error handling path in 'e1000_probe()' Date: Wed, 16 Jun 2021 07:05:53 +0200 Message-Id: <2651bb1778490c45d963122619fe3403fdf6b9de.1623819901.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: 111b9dc5c981 ("e1000e: add aer support") Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/intel/e1000e/netdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 5435606149b0..c8aa69fd0405 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -7662,6 +7662,7 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent) err_ioremap: free_netdev(netdev); err_alloc_etherdev: + pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma: -- 2.30.2