Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161431AbWKHSkW (ORCPT ); Wed, 8 Nov 2006 13:40:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161483AbWKHSkW (ORCPT ); Wed, 8 Nov 2006 13:40:22 -0500 Received: from smtp.osdl.org ([65.172.181.4]:19887 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1161431AbWKHSkV (ORCPT ); Wed, 8 Nov 2006 13:40:21 -0500 Date: Wed, 8 Nov 2006 10:36:54 -0800 (PST) From: Linus Torvalds To: Adrian Bunk , Jeff Chua cc: Matthew Wilcox , Andi Kleen , Aaron Durbin , Andrew Morton , Linux Kernel Mailing List , gregkh@suse.de, linux-pci@atrey.karlin.mff.cuni.cz Subject: Re: [discuss] Re: 2.6.19-rc4: known unfixed regressions (v3) In-Reply-To: Message-ID: References: <20061107171143.GU27140@parisc-linux.org> <200611080839.46670.ak@suse.de> <20061108122237.GF27140@parisc-linux.org> <20061108172650.GC4729@stusta.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1209 Lines: 30 On Wed, 8 Nov 2006, Linus Torvalds wrote: > > I'm going to revert that totally bogus commit that added that broken > "pci_mmcfg_insert_resources()" function. Pushed out. Jeff, can you verify that current git does the right thing. Andi - I also ported the x86 io-apic cleanup and fixes to x86-64. I'll push those out too once I've verified them on the machines I have access to. I'm still not 100% happy about the io-apic thing (for example, I was thinking that maybe we should just automatically choose the order of writes in apic_write_entry() by just checking whether "mask" was set or not), but the code really is cleaner, and on x86 it was verified to fix some things. Keeping in sync is still better than having two different approaches, one of which was confirmed broken. And the i386 code is definitely more tested over the years than the x86-64 code could ever have hoped to be, so going back to the original ordering makes sense. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/