Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 16 Jun 2021 08:50:59 +0200
Message-ID: <s5hfsxi1ewc.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
        <perex@perex.cz>, <tiwai@suse.com>, <broonie@kernel.org>
Subject: Re: [PATCH -next] ALSA: fm801: Fix missing pci_release_regions() on error in snd_fm801_create()
In-Reply-To: <20210616025507.2120103-1-yangyingliang@huawei.com>
References: <20210616025507.2120103-1-yangyingliang@huawei.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 16 Jun 2021 04:55:07 +0200,
Yang Yingliang wrote:
> 
> Fix the missing pci_release_regions() before return
> from snd_fm801_create() in the error handling case.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

pci_regions() is manated in pcim_release(), hence you don't need to
call it explicitly.


thanks,

Takashi