Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp204540pxj; Wed, 16 Jun 2021 00:03:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVOsj9W28TT3tgiHxwB+msC7xbYRABv1AQwDqVMTPGbaSYi9T4b131bdb14iDslcS7TAax X-Received: by 2002:a5e:8342:: with SMTP id y2mr2396038iom.168.1623827000475; Wed, 16 Jun 2021 00:03:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623827000; cv=none; d=google.com; s=arc-20160816; b=Vr2YiBARTwoBJ52JUJbzFDCAjkiGzJ1ov6nUzA/pAJD6KY1A+g6RZ3Hwlh6aMuN839 +whdJ3a0C71Gc1K9ShIdXzIWm4uJ+o0gJRx7Z0ZcsV2FAIIiypx7sy9rR5IClT5aVctz wT5zrlLterQhGVj7s18BxiwUBzOlAoAuxaNpCE9mE83JSrwLRjR+geNOk+aTg+lPV5xq oJtmGjzAbWccu9+cuk0DcKbhZGv6IEqYRRIjFxJWPUCCckh8hdR8r2aWKoDmS3ULSBOJ Q/uh0k+Gi9ZgAoQflUtcG3NU1acvMYNdlFD7S6f4Cl62Xt9qh4AVY7a13OdymCJhdA1v FxjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=QdYW/SlVnXBDJ0H4L+LE5HQKqOZ9ujdjs7140DqXkoY=; b=KChhb3fv4iA2/zLeRIbpWJY0riOpjADcSjDB92aVoovsk4ztGPgyAchOUpzrHInj6S PUNt+CIE6dsV+XhDI8ywZpR1URx8X9856qEMlv8sf4xjzi20G1keFs0LiES2BBpJbZCu m/bvAEGSe4c6cYKSbfoq+hUagYdp1exkmKGpY65XhgTQh0VSKc9TBbHHVj03tiqcL9ko /FdYDOiRkQeDbn2XyUAdGKJN0cBh9w5QYMzjCJb/U/2svaY9tReMUzpbi0m/55UorbDE 3FmaspqPwO4/lfWgabV68q2uUIj5893ybNwxgCdm3vibncwDBULZQmt/QhTikhzNDUBI Cg2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p11si1404021ilp.48.2021.06.16.00.03.07; Wed, 16 Jun 2021 00:03:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230527AbhFPHEn (ORCPT + 99 others); Wed, 16 Jun 2021 03:04:43 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:4939 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230482AbhFPHEm (ORCPT ); Wed, 16 Jun 2021 03:04:42 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G4bdk0Fcgz6wG7; Wed, 16 Jun 2021 14:59:22 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 15:02:31 +0800 Received: from [10.174.178.174] (10.174.178.174) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 15:02:31 +0800 Subject: Re: [PATCH -next] ALSA: fm801: Fix missing pci_release_regions() on error in snd_fm801_create() To: Takashi Iwai CC: , , , , References: <20210616025507.2120103-1-yangyingliang@huawei.com> From: Yang Yingliang Message-ID: <80aeb5eb-f06e-4069-171c-ed8a84a15a69@huawei.com> Date: Wed, 16 Jun 2021 15:02:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.178.174] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/16 14:50, Takashi Iwai wrote: > On Wed, 16 Jun 2021 04:55:07 +0200, > Yang Yingliang wrote: >> Fix the missing pci_release_regions() before return >> from snd_fm801_create() in the error handling case. >> >> Reported-by: Hulk Robot >> Signed-off-by: Yang Yingliang > pci_regions() is manated in pcim_release(), hence you don't need to > call it explicitly. OK. Thanks, Yang > > > thanks, > > Takashi > .