Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp216860pxj; Wed, 16 Jun 2021 00:22:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyW6F87IHedOvHgcn7H3dJy7haHiho+VxEZ3SqnIP7Xo1GR/K3iLF/FbgWWLvdUDBO2UoJV X-Received: by 2002:aa7:de18:: with SMTP id h24mr2461855edv.23.1623828137777; Wed, 16 Jun 2021 00:22:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623828137; cv=none; d=google.com; s=arc-20160816; b=gJzyh8kvCIeVjYEii28ybdQSKgPrRbk4/iri8t5+uvO4Zm3TYhGE8L01Zy5YLkEVaS Q+0NlfuEoES0+P7sp4Igtqk+JEWOHbvfQrmh8BsOo1ssj42IXZNg42jqqWPJuBkLZUNg ifXC6VhIFf76ON13K8S3j1ONxYuaSk0mPj31p9Adm4vfQGZb0CsBNsXV+KmL+WdTcXJL N+THUX7sHEgw84zLAY1ISUTLqcAF5/B0+aoVNMIMmn3EsMHC18fKc4KcNf1i8KpErtor NbKuNY9pcDbe8lPLGqpSiwQtkovPjDfP6DXxd9AtEFTGiiO8eW/x/mvaTWRNY4wRGYi/ RiQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=ell4BUrMgrtyqS9cInjZM3Ta31GxY1IGr3t7oJoqWfg=; b=cWybXo39/0FvA/9BGDhPnXAwGUT39aaZw0HIHHAeYa3ZT1K22vz6JfwcTLYQmH4jIe fCFzNhS40o1uXBL5o0JAjhegbhHOuOm7sM7m06M6a7o6VsSjymO3IYRNKeAfdoyHFvul RwGsJHqfHEvH2CFKDCD+fvqmELZs8vf9zxSA2RyNV10HcU7YvQvIk4aHRcZcMtc0qDci JQf8hsHjf604zWZ79216j/ZcZkj+a/tiKWWxv/dsr3lMipbiCHcdut55fvv+e0OxpCyN Dtu4gOOroU8i2CSi8F6lPi7u5fa74LRqfmlBryb6700Ddw/mQqc+WFmK23NSshPNM9xY ZUWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id aq5si1558774ejc.19.2021.06.16.00.21.55; Wed, 16 Jun 2021 00:22:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231335AbhFPHXI (ORCPT + 99 others); Wed, 16 Jun 2021 03:23:08 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:57471 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231239AbhFPHXH (ORCPT ); Wed, 16 Jun 2021 03:23:07 -0400 Received: from mail-ed1-f70.google.com ([209.85.208.70]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1ltPrB-00050X-6X for linux-kernel@vger.kernel.org; Wed, 16 Jun 2021 07:21:01 +0000 Received: by mail-ed1-f70.google.com with SMTP id y7-20020aa7ce870000b029038fd7cdcf3bso501774edv.15 for ; Wed, 16 Jun 2021 00:21:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ell4BUrMgrtyqS9cInjZM3Ta31GxY1IGr3t7oJoqWfg=; b=AMvUhkWICzr/Ed1Tn0N94nJrjHGLmH/u5eqWXTryekR+cI8sH04O8GmX7DqZjxzOcZ Kyet1D0g+0HO0ZPKFWj3Cm0CwvKmfqBYOXR1lphyyNyjhXnP4h3r9xqgHKY+Ydcvp2zj QTQaoOmzaBf7zDcFMUwsnNB93pk0AaMuJ1e1pZf3hpXk17joBUHkzW4Jyw3jYE9KoPCK E+mRFGFdLegC0Cpmvpql4W9MykUEJiCqex/iunb8qyFKmRUInoUq1pIoanzH++6A5Oxk cgdBqgh+o7wq0QLIBTnxy8UKwX/Fzmsx1p87XDPIAkpb+NJslnt6e08l9FhYf5uq1rhZ yV6A== X-Gm-Message-State: AOAM533XvdFDBurAIuH6e4BPNIZRHvi3vT7HpeKtfJQaPTmrn+s2xvDW TtoMWcVK3XqIHMlxTpNtfe22yCf1rPBex9CmbbLCQ44tE+OzJks5XhZi7EI1YwmiRETlkemp4EB TcVScKH3v6dHd6XBLIaeecdkZoIX5rahaHh9xOOfRoQ== X-Received: by 2002:a05:6402:268f:: with SMTP id w15mr2494842edd.228.1623828060908; Wed, 16 Jun 2021 00:21:00 -0700 (PDT) X-Received: by 2002:a05:6402:268f:: with SMTP id w15mr2494832edd.228.1623828060690; Wed, 16 Jun 2021 00:21:00 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id x13sm978468ejj.21.2021.06.16.00.21.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 00:21:00 -0700 (PDT) Subject: Re: [GIT PULL] memory: Tegra for v5.14, part two To: Olof Johansson Cc: Arnd Bergmann , arm@kernel.org, soc@kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Thierry Reding , Will Deacon References: <20210614195200.21657-1-krzysztof.kozlowski@canonical.com> <20210615154155.GE11724@lx2k> From: Krzysztof Kozlowski Message-ID: Date: Wed, 16 Jun 2021 09:20:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210615154155.GE11724@lx2k> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/06/2021 17:41, Olof Johansson wrote: > Hi, > > > On Mon, Jun 14, 2021 at 09:52:00PM +0200, Krzysztof Kozlowski wrote: >> Hi Arnd and Olof, >> >> Tegra got quite big rework this cycle. The last piece comes from Thierry, >> however it depends on one patch in Will's tree. Since the last Thierry's >> patches depend both on that one patch and other memory controller drivers >> changes, they are here. >> >> Best regards, >> Krzysztof > > So, this pull request is a bit weird. It contains a lot more than what the > email indicates: > >> The following changes since commit 393d66fd2cacba3e6aa95d7bb38790bfb7b1cc3a: >> >> memory: tegra: Implement SID override programming (2021-06-03 21:50:43 +0200) > > This seems to be a patch in the middle of the new material in your branch, not > the start of what we already have in our tree. > > As a result, the diffstat when we merge looks completely different. While > I generally trust you to not try to squeeze in material under the radar, it's > also unfortunately making it hard to double-check that you didn't accidentally > bring in something you didn't mean to. > > So, before I merge this.. can you confirm, or even better generate a full pull > request summary/diffstat/pull request email that shows the full new material? There should be nothing hidden and I created this pull request on top of my previous Tegra one: "[GIT PULL] memory: Tegra memory controller for v5.14" https://lore.kernel.org/lkml/20210607084910.21024-1-krzysztof.kozlowski@canonical.com/ I had impression you pulled that in, but now I don't see the such branch in the soc tree. Maybe that's the answer - the earlier material was never in? Anyway, before is the full diffstat of that branch so: tags/memory-controller-drv-tegra-5.14 + tags/memory-controller-drv-tegra-5.14-2 However I think it is still good to pull tags/memory-controller-drv-tegra-5.14 first, so the tag-message won't get lost. That tag-message was also explaining why there is a pull from Thierry (with clock and regulator). The second pull does not mention earlier material. ===== The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-mem-ctrl.git tags/memory-controller-drv-tegra-5.14-2 for you to fetch changes up to 2c1bc371268862a991a6498e1dddc8971b9076b8: iommu/arm-smmu: Use Tegra implementation on Tegra186 (2021-06-11 08:44:53 +0200) ---------------------------------------------------------------- Memory controller drivers for v5.14 - Tegra SoC, part two Second set of changes for Tegra SoC memory controller drivers, containing patchset from Thierry Reding: "The goal here is to avoid early identity mappings altogether and instead postpone the need for the identity mappings to when devices are attached to the SMMU. This works by making the SMMU driver coordinate with the memory controller driver on when to start enforcing SMMU translations. This makes Tegra behave in a more standard way and pushes the code to deal with the Tegra-specific programming into the NVIDIA SMMU implementation." This pulls a dependency from Will Deacon (ARM SMMU driver) and contains further ARM SMMU driver patches to resolve complex dependencies between different patchsets. The pull from Will contains only one patch ("Implement ->probe_finalize()"). Further work in Will's tree might depend on this patch, therefore patch was applied there. On the other hand, this ("Implement ->probe_finalize()") patch is also a dependency for ARM SMMU driver changes for Tegra. These changes, bringing seamless transition from the firmware framebuffer to the OS framebuffer, depend on earlier Tegra memory controller driver patches. ---------------------------------------------------------------- Dan Carpenter (1): memory: tegra: Delete dead debugfs checking code Dmitry Osipenko (18): clk: tegra30: Use 300MHz for video decoder by default clk: tegra: Fix refcounting of gate clocks clk: tegra: Ensure that PLLU configuration is applied properly clk: tegra: Halve SCLK rate on Tegra20 clk: tegra: Don't allow zero clock rate for PLLs clk: tegra: cclk: Handle thermal DIV2 CPU frequency throttling clk: tegra: Mark external clocks as not having reset control clk: tegra: Don't deassert reset on enabling clocks regulator: core: Add regulator_sync_voltage_rdev() soc/tegra: regulators: Bump voltages on system reboot soc/tegra: Add stub for soc_is_tegra() soc/tegra: Add devm_tegra_core_dev_init_opp_table() soc/tegra: fuse: Add stubs needed for compile-testing clk: tegra: Add stubs needed for compile-testing memory: tegra: Fix compilation warnings on 64bit platforms memory: tegra: Enable compile testing for all drivers memory: tegra20-emc: Use devm_tegra_core_dev_init_opp_table() memory: tegra30-emc: Use devm_tegra_core_dev_init_opp_table() Krzysztof Kozlowski (2): Merge tag 'tegra-for-5.14-memory' of https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux into for-v5.14/tegra-mc Merge branch 'for-thierry/arm-smmu' of https://git.kernel.org/pub/scm/linux/kernel/git/will/linux into for-v5.14/tegra-mc Thierry Reding (21): Merge branch 'for-5.14/regulator' into for-5.14/soc Merge branch 'for-5.14/clk' into for-5.14/memory Merge branch 'for-5.14/soc' into for-5.14/memory memory: tegra: Consolidate register fields memory: tegra: Unify struct tegra_mc across SoC generations memory: tegra: Introduce struct tegra_mc_ops memory: tegra: Push suspend/resume into SoC drivers memory: tegra: Make per-SoC setup more generic memory: tegra: Extract setup code into callback memory: tegra: Parameterize interrupt handler memory: tegra: Make IRQ support opitonal memory: tegra: Only initialize reset controller if available memory: tegra: Unify drivers memory: tegra: Add memory client IDs to tables memory: tegra: Split Tegra194 data into separate file memory: tegra: Implement SID override programming iommu/arm-smmu: Implement ->probe_finalize() dt-bindings: arm-smmu: Add Tegra186 compatible string iommu/arm-smmu: tegra: Detect number of instances at runtime iommu/arm-smmu: tegra: Implement SID override programming iommu/arm-smmu: Use Tegra implementation on Tegra186 .../devicetree/bindings/iommu/arm,smmu.yaml | 11 +- drivers/clk/tegra/clk-periph-gate.c | 80 +- drivers/clk/tegra/clk-periph.c | 11 + drivers/clk/tegra/clk-pll.c | 12 +- drivers/clk/tegra/clk-tegra-periph.c | 6 +- drivers/clk/tegra/clk-tegra-super-cclk.c | 16 +- drivers/clk/tegra/clk-tegra20.c | 6 +- drivers/clk/tegra/clk-tegra30.c | 6 +- drivers/clk/tegra/clk.h | 4 - drivers/iommu/arm/arm-smmu/arm-smmu-impl.c | 3 +- drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c | 90 +- drivers/iommu/arm/arm-smmu/arm-smmu.c | 13 + drivers/iommu/arm/arm-smmu/arm-smmu.h | 1 + drivers/iommu/tegra-smmu.c | 16 +- drivers/memory/tegra/Kconfig | 18 +- drivers/memory/tegra/Makefile | 6 +- drivers/memory/tegra/mc.c | 321 ++-- drivers/memory/tegra/mc.h | 25 + drivers/memory/tegra/tegra114.c | 1245 ++++++++------- drivers/memory/tegra/tegra124-emc.c | 8 +- drivers/memory/tegra/tegra124.c | 1306 ++++++++------- drivers/memory/tegra/tegra186.c | 1679 ++++++-------------- drivers/memory/tegra/tegra194.c | 1351 ++++++++++++++++ drivers/memory/tegra/tegra20-emc.c | 52 +- drivers/memory/tegra/tegra20.c | 110 +- drivers/memory/tegra/tegra210-emc-core.c | 4 - drivers/memory/tegra/tegra210.c | 1433 +++++++++-------- drivers/memory/tegra/tegra30-emc.c | 56 +- drivers/memory/tegra/tegra30.c | 1292 ++++++++------- drivers/regulator/core.c | 23 + drivers/soc/tegra/common.c | 97 ++ drivers/soc/tegra/pmc.c | 5 - drivers/soc/tegra/regulators-tegra20.c | 75 +- drivers/soc/tegra/regulators-tegra30.c | 75 +- include/linux/clk/tegra.h | 100 +- include/linux/regulator/driver.h | 1 + include/soc/tegra/common.h | 31 + include/soc/tegra/fuse.h | 20 +- include/soc/tegra/mc.h | 65 +- 39 files changed, 5662 insertions(+), 4011 deletions(-) create mode 100644 drivers/memory/tegra/tegra194.c Best regards, Krzysztof