Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 16 Jun 2021 16:11:52 +0800
Message-ID: <8735tigref.wl-chenli@uniontech.com>
From:   Chen Li <chenli@uniontech.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] ramfs: skip mknod if inode already =?GB2312?B?ZXhp?=
 =?GB2312?B?c3RzLqG+x+vXotLio6zTyrz+08liYXR2K2FlODk4OWUxNjY4Zjg0YTc0ZDM3?=
 =?GB2312?B?KzY1MDYraW5mcmFkZWFkLm9yZytoY2hAY2FzcGVyLnNycy5pbmZyYWRlYWQu?=
 =?GB2312?B?b3JntPq3oqG/?=
In-Reply-To: <YMmHwTZaahtmjK2z@infradead.org>
References: <874kdyh65j.wl-chenli@uniontech.com>
        <YMmHwTZaahtmjK2z@infradead.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0
 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 16 Jun 2021 13:10:25 +0800,
Christoph Hellwig wrote:
> 
> On Wed, Jun 16, 2021 at 10:53:12AM +0800, Chen Li wrote:
> > 
> > It's possible we try to mknod a dentry, which have
> > already bound to an inode, just skip it.
> 
> How do you think this could happen?
> 
> 

Sorry, that's my bad. I noticed unionfs used to do this check in 9c5b4452998c6e670cfde0928b277e9c50d9a676, but not sure is it a must.