Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
User-Agent: Cyrus-JMAP/3.5.0-alpha0-526-gf020ecf851-fm-20210616.001-gf020ecf8
Mime-Version: 1.0
Message-Id: <ec3af3d1-204b-4dbb-8c36-a33764c798e8@www.fastmail.com>
In-Reply-To: <20210616034458.3499522-3-axel.lin@ingics.com>
References: <20210616034458.3499522-1-axel.lin@ingics.com>
 <20210616034458.3499522-3-axel.lin@ingics.com>
Date:   Wed, 16 Jun 2021 18:33:39 +1000
From:   Alistair <alistair@alistair23.me>
To:     "Axel Lin" <axel.lin@ingics.com>, "Mark Brown" <broonie@kernel.org>
Cc:     "Lars Ivar Miljeteig" <lars.ivar.miljeteig@remarkable.com>,
        "Liam Girdwood" <lgirdwood@gmail.com>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: =?UTF-8?Q?Re:_[PATCH_3/3]_regulator:_sy7636a:_Use_rdev=5Fget=5Fdrvdata_a?=
 =?UTF-8?Q?t_proper_place?=
Content-Type: text/plain
Precedence: bulk

On Wed, Jun 16, 2021, at 1:44 PM, Axel Lin wrote:
> At the context with *rdev, use rdev_get_drvdata() is more intuitive.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Reviewed-by: Alistair Francis <alistair@alistair23.me>

> ---
> drivers/regulator/sy7636a-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/sy7636a-regulator.c b/drivers/regulator/sy7636a-regulator.c
> index c71c0a007d95..e021ae08cbaa 100644
> --- a/drivers/regulator/sy7636a-regulator.c
> +++ b/drivers/regulator/sy7636a-regulator.c
> @@ -35,7 +35,7 @@ static int sy7636a_get_vcom_voltage_op(struct regulator_dev *rdev)
>  
> static int sy7636a_get_status(struct regulator_dev *rdev)
> {
> - struct sy7636a *sy7636a = dev_get_drvdata(rdev->dev.parent);
> + struct sy7636a *sy7636a = rdev_get_drvdata(rdev);
> int ret = 0;
>  
> ret = gpiod_get_value_cansleep(sy7636a->pgood_gpio);
> -- 
> 2.25.1
> 
>