Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 16 Jun 2021 10:03:17 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Yunus Bas <y.bas@phytec.de>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: mfd-core: Change "Failed to locate of_node" warning
 to debug
Message-ID: <YMm+VXRrRKIHGgmr@dell>
References: <20210616081949.26618-1-y.bas@phytec.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210616081949.26618-1-y.bas@phytec.de>
Precedence: bulk

On Wed, 16 Jun 2021, Yunus Bas wrote:

> The MFD-core iterates through all subdevices of the corresponding
> MFD-device and checks, if the devicetree subnode has a fitting compatible.
> When nothing is found, a warning is thrown. This can be the case, when it
> is the intention to not use the MFD-device to it's full content.
> Therefore, change the warning to a debug print instead, to also avoid
> irritations.
> 
> Signed-off-by: Yunus Bas <y.bas@phytec.de>
> ---
>  drivers/mfd/mfd-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> index 6f02b8022c6d..e34c97088943 100644
> --- a/drivers/mfd/mfd-core.c
> +++ b/drivers/mfd/mfd-core.c
> @@ -213,7 +213,7 @@ static int mfd_add_device(struct device *parent, int id,
>  		}
>  
>  		if (!pdev->dev.of_node)
> -			pr_warn("%s: Failed to locate of_node [id: %d]\n",
> +			pr_debug("%s: Failed to locate of_node [id: %d]\n",
>  				cell->name, platform_id);
>  	}

Can you provide an example of a device tree where this is a problem?

Probably worth popping that in the commit message too.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog