Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 4/7] thermal/drivers/tegra: Add driver for Tegra30
 thermal sensor
To:     Vincent Guittot <vincent.guittot@linaro.org>
Cc:     Viresh Kumar <viresh.kumar@linaro.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Thara Gopinath <thara.gopinath@linaro.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Zhang Rui <rui.zhang@intel.com>,
        Amit Kucheria <amitk@kernel.org>,
        Andreas Westman Dorcsak <hedmoo@yahoo.com>,
        Maxim Schwalm <maxim.schwalm@gmail.com>,
        Svyatoslav Ryhel <clamor95@gmail.com>,
        Ihor Didenko <tailormoon@rambler.ru>,
        Ion Agorria <ion@agorria.com>,
        Matt Merhar <mattmerhar@protonmail.com>,
        Peter Geis <pgwipeout@gmail.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-tegra@vger.kernel.org,
        "open list:THERMAL" <linux-pm@vger.kernel.org>
References: <20210529170955.32574-1-digetx@gmail.com>
 <20210529170955.32574-5-digetx@gmail.com>
 <6f2b6290-095a-bd39-c160-1616a0ff89b1@linaro.org>
 <20210615102626.dja3agclwzxv2sj4@vireshk-i7>
 <595f5e53-b872-bcc6-e886-ed225e26e9fe@gmail.com>
 <fbdc3b56-4465-6d3e-74db-1d5082813b9c@linaro.org>
 <4c7b23c4-cf6a-0942-5250-63515be4a219@gmail.com>
 <20210616080310.vhvauvo5y6m2sekz@vireshk-i7>
 <CAKfTPtAxvj4_TBpFesjQxcVzvEi3QVUThccfSAJXwwrLtOH-xg@mail.gmail.com>
 <96bf59af-20b6-b706-5ff0-fe70f9eba827@gmail.com>
 <CAKfTPtBDzFaFKuYgY5XC+-vFxFSJvxKunGFwY50E98bYn0VE5Q@mail.gmail.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <57e044af-072f-cf7e-8f25-dc8b814c78c5@gmail.com>
Date:   Wed, 16 Jun 2021 13:49:18 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <CAKfTPtBDzFaFKuYgY5XC+-vFxFSJvxKunGFwY50E98bYn0VE5Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

16.06.2021 11:51, Vincent Guittot пишет:
> On Wed, 16 Jun 2021 at 10:39, Dmitry Osipenko <digetx@gmail.com> wrote:
>>
>> 16.06.2021 11:30, Vincent Guittot пишет:
>>> On Wed, 16 Jun 2021 at 10:03, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>>>>
>>>> +Vincent.
>>>>
>>>> On 15-06-21, 22:32, Dmitry Osipenko wrote:
>>>>> IIUC, the cpufreq already should be prepared for the case where firmware
>>>>> may override frequency. Viresh, could you please clarify what are the
>>>>> possible implications of the frequency overriding?
>>>>
>>>> The only implication is software would think hardware is running at
>>>> some other frequency, while it is not. Not sure if something may break
>>>> as a result of this.
>>>>
>>>> The scheduler's view of CPUs will not be same though, i.e. scheduler
>>>> will see capacity as X, while in reality it has changed to Y.
>>>
>>> thermal_pressure is used by scheduler to balance the load between CPUs
>>> according to the actual max frequency. If the thermal pressure doesn't
>>> reflect reality, scheduler will end up enqueuing too many  tasks on a
>>> throttle CPU.
>>
>> What if all CPUs are throttled equally and running on the same
>> frequency, will throttling have any effect on the scheduler decisions?
> 
> Yes, the capacity is also used to detect when CPUs have spare capacity
> or are already overloaded. We usually try to fill the spare capacity
> of a CPU (CPU's max capacity - current utilization) but he max
> capacity is reduced when the CPU is throttled, and the spare capacity
> doesn't exist but scheduler could try to it
> 

Thank you.