Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 16 Jun 2021 12:35:05 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Vinod Koul <vkoul@kernel.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Wolfram Sang <wsa@kernel.org>, linux-arm-msm@vger.kernel.org,
        Andy Gross <agross@kernel.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        Douglas Anderson <dianders@chromium.org>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Amit Pundir <amit.pundir@linaro.org>,
        linux-spi@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] spi: spi-geni-qcom: Add support for GPI dma
Message-ID: <20210616113505.GB6418@sirena.org.uk>
References: <20210111151651.1616813-1-vkoul@kernel.org>
 <20210111151651.1616813-5-vkoul@kernel.org>
 <20210111163504.GD4728@sirena.org.uk>
 <YMm7ZWXnJyb8QT1u@vkoul-mobl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uZ3hkaAS1mZxFaxD"
Content-Disposition: inline
In-Reply-To: <YMm7ZWXnJyb8QT1u@vkoul-mobl>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--uZ3hkaAS1mZxFaxD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 16, 2021 at 02:20:45PM +0530, Vinod Koul wrote:

> Looking at the code, that is ideal case. Only issue I can see is that
> core DMA mapping device being used is incorrect. The core would use
> ctlr->dev.parent which is the spi0 device here.

Why would the parent of the controller be a SPI device?

> But in this case, that wont work. We have a parent qup device which is
> the parent for both spi and dma device and needs to be used for
> dma-mapping!=20

> If we allow drivers to set dma mapping device and use that, then I can
> reuse the core. Let me know if that is agreeable to you and I can hack
> this up. Maybe add a new member in spi_controller which is filled by
> drivers in can_dma() callback?

Possibly, I'd need to see the code.

--uZ3hkaAS1mZxFaxD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDJ4ekACgkQJNaLcl1U
h9Af1wf/XUOdANnfcSkgc6h7gVWBBmYYK7XBQctlluQOJxB4547Z5GJBEqISj560
Fn5NhyLDpooG5dGnHVv9434n1mPZiU7SwUbi1fwwauNe9prWjvZnC4NpUbobm1XX
KFczLzgQZ2QiiVDcry2XQz5+GsmHWDPlcBvN9B2EcM37BUXooUTLoAJmwYbB4kHu
LmY6Su4yZFynekXxcCuZN+8wlCGQEcX89lppEyRH62cyimARLoh4psPJuLBRNwbD
xw+FCLQxBkNVWYZD5v3t2KWCIqewSGUS1YTAAJUCiPftepbsH91CragR2sC6AewR
EXh4LGNP8gNAt38ftvgzwKFGIBC7TA==
=VcFe
-----END PGP SIGNATURE-----

--uZ3hkaAS1mZxFaxD--