Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210616034448.34919-1-yujiahua1@huawei.com>
In-Reply-To: <20210616034448.34919-1-yujiahua1@huawei.com>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Wed, 16 Jun 2021 14:03:32 +0200
Message-ID: <CAG3jFyuJBFM-2KbJM_3FOisD1B8fz=AkAykW5KZfnbROyn3FQQ@mail.gmail.com>
Subject: Re: [PATCH -next] drivers: gpu: add missing MODULE_DEVICE_TABLE in anx7625.c
To:     Yu Jiahua <yujiahua1@huawei.com>
Cc:     Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.co>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, Xin Ji <xji@analogixsemi.com>,
        Hsin-Yi Wang <hsinyi@chromium.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hey Yu,

Thank you for submitting this, it looks good to me and I pulled into
drm-misc-next.

https://cgit.freedesktop.org/drm/drm-misc/commit/?id=ad5fd900a69b1ae24e6b22506dea637b6bbbdb55

On Wed, 16 Jun 2021 at 05:44, Yu Jiahua <yujiahua1@huawei.com> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Signed-off-by: Yu Jiahua <yujiahua1@huawei.com>
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 65cc05982f82..beb01364af4d 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -1830,6 +1830,7 @@ static const struct of_device_id anx_match_table[] = {
>         {.compatible = "analogix,anx7625",},
>         {},
>  };
> +MODULE_DEVICE_TABLE(of, anx_match_table);
>
>  static struct i2c_driver anx7625_driver = {
>         .driver = {
> --
> 2.17.1
>