Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp468784pxj; Wed, 16 Jun 2021 06:40:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztkNMwFtAlgNfgGVi3tTxGeGG4l4AhW0CCGqrYBaWEMm/rA9DCSplXO8g/ybtj5xFl6brM X-Received: by 2002:a02:6382:: with SMTP id j124mr4391053jac.72.1623850805902; Wed, 16 Jun 2021 06:40:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623850805; cv=none; d=google.com; s=arc-20160816; b=UPx17tZArbIxeQJfz/AG65P+5Iu9nkzomJXDff15/mbj0f3if65fmLA0iDjjWn8FLQ ykuQgysh1yDit03TZWF3Fvz5+rT/LgSQTl+Uh8JLdLMpyOsEJx6qNLvyimgrLQZ4epj5 aEEk0zsQcmVwVUiR33UbK7LHy0oPkIiHszBshE9tB+j3fy7qjWpx4qf6d+CndBH6l40C E6ak0VIHq9OLXf+wh/LUa6a7DEw4eLuIf1XlXcpHmwdMkHtmnNjBqwd/U9/vBWesGh2c 2yKzQhA5yCKTIrscE7okY7EwQIt8g/t1pfhWzh96vV9tFJa3qFIU+RQ8ZHkXQxONCcaT zNlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=hMdx2enOCXLeimyLQWKG4juULWTGUPK15DtmAEk9jLM=; b=NgGjDvLPuNzRKxx+L59VhuwbP6Xrk41rJjvY+RGLiXFYB4BJBDuqO+DnQAq4GOBeUy L3bRT8ZaMebEF2tj9zZ6zZFDhgMRYsVJ3uL/lYQ/dRxnz8+SSG1fnuh9ayU7tQ25eLfT loscAfD5korBo+0vJ92cf1xjevRy0ZUxJLwE49l0wtoxAwbnt4Z+BL6VGK6eo5YJf73n qr+0LZeMM14d8N8x8LCPrScNZWsaXCgiJcQsnh/4HrcqplGEMDKVvm1c4dTzQEIADymI QB+PH45RPOPRZzRHKbEbxJU2rEFGSbVUJXAw9usYoEsCxlq5uM5Dc0jTpwJKXKk0Sw0/ LXEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m3si2321161ild.74.2021.06.16.06.39.52; Wed, 16 Jun 2021 06:40:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229560AbhFPM4I (ORCPT + 99 others); Wed, 16 Jun 2021 08:56:08 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:53060 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232550AbhFPM4G (ORCPT ); Wed, 16 Jun 2021 08:56:06 -0400 Received: from localhost (unknown [192.168.167.70]) by lucky1.263xmail.com (Postfix) with ESMTP id CE363CD8BD; Wed, 16 Jun 2021 20:53:40 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from localhost.localdomain (unknown [111.207.172.18]) by smtp.263.net (postfix) whith ESMTP id P4789T140158491260672S1623848013965153_; Wed, 16 Jun 2021 20:53:40 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: <97f3434abaad5f566b0711ee2b3c6bfd> X-RL-SENDER: maqianga@uniontech.com X-SENDER: maqianga@uniontech.com X-LOGIN-NAME: maqianga@uniontech.com X-FST-TO: larry.finger@lwfinger.net X-RCPT-COUNT: 8 X-SENDER-IP: 111.207.172.18 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 From: Qiang Ma To: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, insafonov@gmail.com, yepeilin.cs@gmail.com, ffclaire1224@gmail.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Qiang Ma Subject: [PATCH] staging: r8188eu/core: remove the check for NULL pointer in _rtw_enqueue_cmd() Date: Wed, 16 Jun 2021 20:53:32 +0800 Message-Id: <20210616125332.31674-1-maqianga@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove the check for _rtw_enqueue_cmd(), because rtw_enqueue_cmd() already has a check of NULL pointer, so this condition is not possible. Signed-off-by: Qiang Ma --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c index 1724dfd7edbc..513c0f95b4bf 100644 --- a/drivers/staging/rtl8188eu/core/rtw_cmd.c +++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c @@ -39,17 +39,12 @@ static int _rtw_enqueue_cmd(struct __queue *queue, struct cmd_obj *obj) { unsigned long irqL; - if (!obj) - goto exit; - spin_lock_irqsave(&queue->lock, irqL); list_add_tail(&obj->list, &queue->queue); spin_unlock_irqrestore(&queue->lock, irqL); -exit: - return _SUCCESS; } -- 2.20.1