Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp708448pxj; Wed, 16 Jun 2021 11:41:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlJ1ud8TIUWA1B3wylwo9JRCjTCImBKSms4ZpjqyVD2ANuIHPnF7ZG8UiTe//ZIPppO9Mx X-Received: by 2002:a05:6402:1d38:: with SMTP id dh24mr1452152edb.18.1623868909561; Wed, 16 Jun 2021 11:41:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623868909; cv=none; d=google.com; s=arc-20160816; b=RkEGFhDzigh40Php1IEJmXJxHPqdvf6XYcZOPr/YxEpOYr/ypjp50vMPh2qho6gixI bjYb7n7RQQ+PKfI8nt4RMVPFdnxNjhWkixucHOaQa6Q3XjpV/BrmLvmZigfVqgLi6Znf 0eVuZ7pyxcI/XbSRBdmyMLrFW9UttYV3kK7v8hQ7VNLLghJi2YXlUGOTbu89XsQ2myhh F95FsV5pvtHkctHNsEVvQOhbVwpBqPDmglSTpYnTAIzTmtIHAHe6KEvvMtMgY9jejTZ0 PGD7Mc4kFIr9D9QjUNjkabrQFZqbDs/YPWOj5k0wRmDa2ezzODfU5Eu/orocahwBphKr jeJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=KSb9nfzL+RhzoqwO3ajNx2hHzInvy5nga/uUIlDrTWw=; b=msMls87jXyBPfgKds5/+wNUM8k+AivRjaNVwVNH8+diH9LTElRUTvlXKUJN+WpmJH5 SXmcd/dJSSy4VLvCea4YEiim+HytUnNXz7U2JEqVAZVl+qTCiajvf/LWgi3IRe5f9I7A 0yttEEGY27aDrXo//C/VrXN9kJvjpjmvZG7lYPnKdPr0r72JQKzQUQnBywTFhlEUTqcb XjLi25MuRCPOAuQpCSDZpYRrnI2p5aoEU9rKbDTGYHZ6F+5kpQfCnX+Ql8RP9ldBdjxZ eVo56o2puzX+OjynRvBOblV3rsjnH5sXcHvOwVg4vwA+NCYf9KVo0YZT5lwGXkDV1p1F TVGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jz5si3214670ejb.22.2021.06.16.11.41.26; Wed, 16 Jun 2021 11:41:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233095AbhFPNCP (ORCPT + 99 others); Wed, 16 Jun 2021 09:02:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232223AbhFPNCO (ORCPT ); Wed, 16 Jun 2021 09:02:14 -0400 X-Greylist: delayed 369 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 16 Jun 2021 06:00:08 PDT Received: from magratgarlick.emantor.de (magratgarlick.emantor.de [IPv6:2a01:4f8:c17:c88::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3467C061574 for ; Wed, 16 Jun 2021 06:00:08 -0700 (PDT) Received: by magratgarlick.emantor.de (Postfix, from userid 114) id A415485E61; Wed, 16 Jun 2021 14:53:54 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on magratgarlick.emantor.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from localhost (unknown [IPv6:2001:9e8:217c:d502:c0d3:dbff:fefe:ff70]) by magratgarlick.emantor.de (Postfix) with ESMTPSA id E605E85E38; Wed, 16 Jun 2021 14:53:52 +0200 (CEST) From: Rouven Czerwinski To: Liam Girdwood , Mark Brown Cc: kernel@pengutronix.de, Rouven Czerwinski , linux-kernel@vger.kernel.org Subject: [PATCH] regulator: fixed: use dev_err_probe for gpio Date: Wed, 16 Jun 2021 14:53:31 +0200 Message-Id: <20210616125331.153414-1-r.czerwinski@pengutronix.de> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of returning the the PTR_ERR directly, use dev_err_probe which will also correctly set the deferred probe reason in /sys/kernel/debug/deferred_devices, making it easier to debug missing devices on the system. Signed-off-by: Rouven Czerwinski --- drivers/regulator/fixed.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c index 02ad83153e19..78f3a938b39b 100644 --- a/drivers/regulator/fixed.c +++ b/drivers/regulator/fixed.c @@ -271,7 +271,8 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev) */ cfg.ena_gpiod = gpiod_get_optional(&pdev->dev, NULL, gflags); if (IS_ERR(cfg.ena_gpiod)) - return PTR_ERR(cfg.ena_gpiod); + return dev_err_probe(&pdev->dev, PTR_ERR(cfg.ena_gpiod), + "can't get GPIO\n"); cfg.dev = &pdev->dev; cfg.init_data = config->init_data; -- 2.31.1