Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 5nHsB4ZNwOi4OtK/Mv6ZZb42bNhIIw9NyYRwUxrmQLPFIO4p4sx6qYeOS9iNgtJDJb98pdH+Kj
 Gdfg3aIGAMMg==
IronPort-SDR: 4ifLwTPG2xbTZHbYoF5hGsNUnevWj1VkQxVOk+X1SePuSzEovjT2+CXsbMddFTEXYggTKtDwwP
 DUhZOdShrpDA==
Date:   Wed, 16 Jun 2021 16:41:20 +0300
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Kyle Tso <kyletso@google.com>
Cc:     linux@roeck-us.net, gregkh@linuxfoundation.org, badhri@google.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tcpm: Ignore Vsafe0v in
 PR_SWAP_SNK_SRC_SOURCE_ON state
Message-ID: <YMn/gIwB3noYWuHA@kuha.fi.intel.com>
References: <20210615173206.1646477-1-kyletso@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210615173206.1646477-1-kyletso@google.com>
Precedence: bulk

On Wed, Jun 16, 2021 at 01:32:06AM +0800, Kyle Tso wrote:
> In PR_SWAP_SNK_SRC_SOURCE_ON state, Vsafe0v is expected as well so do
> nothing here to avoid state machine going into SNK_UNATTACHED.
> 
> Fixes: 28b43d3d746b ("usb: typec: tcpm: Introduce vsafe0v for vbus")
> Signed-off-by: Kyle Tso <kyletso@google.com>

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tcpm/tcpm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 197556038ba4..e11e9227107d 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -5212,6 +5212,7 @@ static void _tcpm_pd_vbus_vsafe0v(struct tcpm_port *port)
>  		}
>  		break;
>  	case PR_SWAP_SNK_SRC_SINK_OFF:
> +	case PR_SWAP_SNK_SRC_SOURCE_ON:
>  		/* Do nothing, vsafe0v is expected during transition */
>  		break;
>  	default:
> -- 
> 2.32.0.272.g935e593368-goog

-- 
heikki