Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp752301pxj; Wed, 16 Jun 2021 12:46:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXE4nVzXmLDMAZp7R1/Vqfrhd2yH4QGFXxl9pJGQm6eplMOlSAI0piEsoK/3s0jSV9/5nq X-Received: by 2002:a02:9f97:: with SMTP id a23mr944231jam.114.1623872765406; Wed, 16 Jun 2021 12:46:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623872765; cv=none; d=google.com; s=arc-20160816; b=COoRgYoAufTn3BVPfT5O861flEp9SxWAkN8eaEGjK4rwbhTMwcXPA4MNGH+B4qwzES 3EMKttM8jkhYEq+9suPjshQi9QfuwRzzOyL9lPFNENIMCXqKbXYF3I5GdETdppxr+S/c cRvepgHDx7J3WugwlYldk0Zs6vXvLlbgs8ZSySAn4+gRFVEudMfJxKUS0XygaxSLfw5J E2s1p6TnVpWJV1ruM+zUYVVcu11/euUOUoSsP2fG2BByPGdSlwOIqOLW2sq49ODMkaB6 KcauOG3LqDk+smsipuHnoavyfrK91B1/NglMbfoygfLxRDHugi0woS3FWYKg2Ye1pIW1 6DQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:references:in-reply-to:from :organization:dkim-signature; bh=p8GK50I3KBKc8B6YusjGKlCOchxcM/TeXaVsgxynpE4=; b=KDbyvRWsZZTj9WBvM2qzLlhiz5iGRaquvfzuz2VG0mXp/K19yDcdmhPMuelsbf8mQB jjrT5tDXlTb/WZE0ehUMyOiKbKpuxJTlsN0PcHIdtKkZ3M/w8SnkpUrBtQCsJXeY7l6l hFIK0E6n3Ww+we8IqaBB7vBxo5TE+MKvmG+vTKro9Zz00vZm/qLcdNurWTXBIgW7Z49q YSuLZUJkhpnIUyoET9wKNY9HcRqaLtYsy05wRfNXRj1NMAT2fSixs9vs5Snl6jhnh/OU sQ3abXUIUUK19YDLiDqQtwLNz4IoaZZoguGVU+Kjr3QuQ9SbXm8xNm/Z0gU5s7ZUBArw yARA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KaxONaED; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z21si3350774ioq.36.2021.06.16.12.45.52; Wed, 16 Jun 2021 12:46:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KaxONaED; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233020AbhFPNns (ORCPT + 99 others); Wed, 16 Jun 2021 09:43:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:60033 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232199AbhFPNnr (ORCPT ); Wed, 16 Jun 2021 09:43:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623850900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p8GK50I3KBKc8B6YusjGKlCOchxcM/TeXaVsgxynpE4=; b=KaxONaEDpeYNdHhqoI2a26Gqi+BYEJFtj6yRID2YLDx3gGGHOK1T5nqthwAaqT2i/0w48v QiIu/CrJyOhz1j9zA8oUGGm3LnW1oIpQB/yjqHoJ0tLNdUw1suAE0JNfcmM9BfcwayjCSO WWvgKOt79xK78g+sNU9viGn34aMRWKE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-84-PT56Y0xWN_GyKRNQvyK7Zg-1; Wed, 16 Jun 2021 09:41:39 -0400 X-MC-Unique: PT56Y0xWN_GyKRNQvyK7Zg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0D78319251AD; Wed, 16 Jun 2021 13:41:38 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-118-65.rdu2.redhat.com [10.10.118.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1FCBF10016F4; Wed, 16 Jun 2021 13:41:35 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <200ea6f7-0182-9da1-734c-c49102663ccc@redhat.com> References: <200ea6f7-0182-9da1-734c-c49102663ccc@redhat.com> <162375813191.653958.11993495571264748407.stgit@warthog.procyon.org.uk> <051421e0-afe8-c6ca-95cd-4dc8cd20a43e@huawei.com> To: Tom Rix Cc: dhowells@redhat.com, Zheng Zengkai , Randy Dunlap , Linus Torvalds , Hulk Robot , linux-afs@lists.infradead.org, Marc Dionne , linux-fsdevel , Linux Kernel Mailing List Subject: Re: [PATCH] afs: fix no return statement in function returning non-void MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <929459.1623850895.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Wed, 16 Jun 2021 14:41:35 +0100 Message-ID: <929460.1623850895@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tom Rix wrote: > A fix is to use the __noreturn attribute on this function and not add a = return > like this > = > -static int afs_dir_set_page_dirty(struct page *page) > +static int __noreturn afs_dir_set_page_dirty(struct page *page) > = > and to the set of ~300 similar functions in these files. BUG() really ought to handle it. Do you have CONFIG_BUG=3Dy? David