Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: h9ntA3AlpPQPPSUpTuCkks20OTtpOVNyaJtpOWNccpnzsNhxr/nbPauds325mtZSaD5zubDnd3
 NXyt5C+dypX4euM+57YGVQQq5rrbmbhuLPRdidofr2s16ibLSnIBddmGKlPprT3cPIa9pG1EgF
 HVkM0XX35VEtOle/zm2ecsE5p5r89ZP1yWUWW/JX3eDwaS3hhaZ3UuoB5vSyeBXRDoSaOi0/9s
 pn364uPTT4OvF4CbUzJubR02S/eFj1XiwknjjTKKd2C/SgV3ToFSI9VvGNYBL3d0Ep7COFhXUd
 QRE=
From:   Aravind Ramesh <Aravind.Ramesh@wdc.com>
To:     Niklas Cassel <Niklas.Cassel@wdc.com>,
        Jens Axboe <axboe@kernel.dk>, Hannes Reinecke <hare@suse.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Damien Le Moal <Damien.LeMoal@wdc.com>,
        Shaun Tancheff <shaun@tancheff.com>
CC:     Damien Le Moal <Damien.LeMoal@wdc.com>,
        Niklas Cassel <Niklas.Cassel@wdc.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Jens Axboe <axboe@fb.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 2/2] blk-zoned: allow BLKREPORTZONE without
 CAP_SYS_ADMIN
Thread-Topic: [PATCH v3 2/2] blk-zoned: allow BLKREPORTZONE without
 CAP_SYS_ADMIN
Thread-Index: AQHXYRgoQPSf84k1AUaPPMUo9Yx7E6sWqOwg
Date:   Wed, 16 Jun 2021 13:43:39 +0000
Message-ID: <BYAPR04MB40565D2E221DDAA74288577A8C0F9@BYAPR04MB4056.namprd04.prod.outlook.com>
References: <20210614122303.154378-1-Niklas.Cassel@wdc.com>
 <20210614122303.154378-3-Niklas.Cassel@wdc.com>
In-Reply-To: <20210614122303.154378-3-Niklas.Cassel@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ymO+UAwUPS5v4dcpBFMh4Jw4k3aYi6+5LgOQ7u6pUXfGMElVwDSyOwQMAzJe?=
 =?us-ascii?Q?DHjKcttEOCXoAsKLqWwWdnQaZstGAXq1CuDYlZM3N6DU1InZYQC/bOMgWaV3?=
 =?us-ascii?Q?RaSGKjN1XrjSdJ9HFqBvhdsrPzPeRVwVfGtVa5PZT8O4XTqRGWQzNQkPg5LV?=
 =?us-ascii?Q?QScS4GMLJcVzv/gVyTgFQfJl0Ob3y9me4RVtce0QAAhbVH2Bo9lbYXSA30qo?=
 =?us-ascii?Q?OEqFrMBB8Kgm0n7P15KgLa7AzK4Sb93Azo+MALszA9Ds3QDnZz46Oy+0gG5c?=
 =?us-ascii?Q?fsSAjNn6xB53JaxqBsuzKLmYXeptizzXHK8KoisEi9187TdhJMu4NzfkqRoU?=
 =?us-ascii?Q?0byfdsuS9EJSEZtjbbqDZ1yxIpnsQdVQW1cPfVuV4d9dcQm0dsmAOhrPGHgj?=
 =?us-ascii?Q?i9R86x/qv37GOVOfSeSfNnDleakf9k7qLHsGIgu8jzwhqzkqO27OvELNJG1Q?=
 =?us-ascii?Q?cIiq7S9P7KQtyy5Tz3NS5aILfAIK1NGtTqx4WrImDb7i4PSDM30FsKt19525?=
 =?us-ascii?Q?DUFP8XkGNdrJ+Xe9C1afoTEUIS6OSa0eEGAvmdSz/Sh3JNIeQHzgvydZrmrR?=
 =?us-ascii?Q?Z3tGmCQOvw+YTKlgl5rS6jJCmkJsxGfCd+UbScDw9MFJf89lCyYvXQvNOx/g?=
 =?us-ascii?Q?GEDKlyxUoy7fmC4Crxe+U0AZz9JqjYtFc7QV93Z0vF/1SWT3EEYkuEnnSqYJ?=
 =?us-ascii?Q?/LXCwmV3wrLR2F3Bnrxjdq3WnyyarWxW9Md42oQqFggwdSrKBiWbCGfnMaHZ?=
 =?us-ascii?Q?LsPwUgjpCueBeayYGXRrUIyzkpXXsCDKIia05/+D5GOF1D5Aa548RHce8HvY?=
 =?us-ascii?Q?WBKNmoVHsEvjuAEIleDoANCxZDsUAzvWzHHUdp7CusY8gmzDxC5jbIdD1x3c?=
 =?us-ascii?Q?AvBREOmN19yIDbmov4cGJEoly8buU1pfW/ntvUdRFZFJen8t2mxosy/4o9FA?=
 =?us-ascii?Q?c4+ondh6x1oO+a0KmIKwq2z8Ec6/h4TjqK94sXJDW9CYKL+j7MX1ZS4602CJ?=
 =?us-ascii?Q?UXYp7spXQHPl1fdSW13SiSd5oaIvc4JL8Sd2PMqLJmfV7TX89EJjk/Oox1/9?=
 =?us-ascii?Q?a7DocvBaUwzFqtxvMyyrw7Tmvbs26vswn7psGxKASL88O3jMhxHVEJKmt9J2?=
 =?us-ascii?Q?rsG42UIZtSbyAWh57aYLoT0hoHa43qx2TPrno3/+RHlLz2iMJuLXM/oJbiHR?=
 =?us-ascii?Q?xqFf3lCyP4iAzDH9x6Bm/cSnZFjyX4iwHRRsJJiAERBkroylxft3zlIZfxjM?=
 =?us-ascii?Q?1WPgXIvk1Bt44YvkuGB4jls52h9gTwqzj4Hhdp6fuUh1By6lpQPYLprFEdmm?=
 =?us-ascii?Q?TUM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR04MB4056.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 60133fa9-ff83-4642-734d-08d930ccbfeb
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2021 13:43:40.0066
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vKHns7yR1HZFSlAUxAaJeS41IpxTYLT+Iy8K99egIc8iYhpl4b/g+h2TTyl+ZHW9V0aGtzC62LKa7VWjjktkGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB6133
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Niklas Cassel <Niklas.Cassel@wdc.com>
> Sent: Monday, June 14, 2021 5:53 PM
> To: Jens Axboe <axboe@kernel.dk>; Hannes Reinecke <hare@suse.com>; Martin=
 K.
> Petersen <martin.petersen@oracle.com>; Damien Le Moal
> <Damien.LeMoal@wdc.com>; Shaun Tancheff <shaun@tancheff.com>
> Cc: Damien Le Moal <Damien.LeMoal@wdc.com>; Niklas Cassel
> <Niklas.Cassel@wdc.com>; stable@vger.kernel.org; Jens Axboe <axboe@fb.com=
>;
> linux-block@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH v3 2/2] blk-zoned: allow BLKREPORTZONE without
> CAP_SYS_ADMIN
>=20
> From: Niklas Cassel <niklas.cassel@wdc.com>
>=20
> A user space process should not need the CAP_SYS_ADMIN capability set in =
order to
> perform a BLKREPORTZONE ioctl.
>=20
> Getting the zone report is required in order to get the write pointer.
> Neither read() nor write() requires CAP_SYS_ADMIN, so it is reasonable th=
at a user
> space process that can read/write from/to the device, also can get the wr=
ite pointer.
> (Since e.g. writes have to be at the write
> pointer.)
>=20
> Fixes: 3ed05a987e0f ("blk-zoned: implement ioctls")
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
> Cc: stable@vger.kernel.org # v4.10+
> ---
> Changes since v2:
> -Drop the FMODE_READ check. Right now it is possible to open() the device=
 with
> O_WRONLY and get the zone report from that fd. Therefore adding a FMODE_R=
EAD
> check on BLKREPORTZONE would break existing applications. Instead, just r=
emove
> the existing CAP_SYS_ADMIN check.
>=20
>  block/blk-zoned.c | 3 ---
>  1 file changed, 3 deletions(-)
>=20
> diff --git a/block/blk-zoned.c b/block/blk-zoned.c index
> 0789e6e9f7db..457eceabed2e 100644
> --- a/block/blk-zoned.c
> +++ b/block/blk-zoned.c
> @@ -288,9 +288,6 @@ int blkdev_report_zones_ioctl(struct block_device *bd=
ev,
> fmode_t mode,
>  	if (!blk_queue_is_zoned(q))
>  		return -ENOTTY;
>=20
> -	if (!capable(CAP_SYS_ADMIN))
> -		return -EACCES;
> -
>  	if (copy_from_user(&rep, argp, sizeof(struct blk_zone_report)))
>  		return -EFAULT;
>=20
> --
> 2.31.1

Looks good,

Reviewed-by: Aravind Ramesh <aravind.ramesh@wdc.com>