Date: Wed, 8 Nov 2006 17:11:07 -0500
From: Dave Jones <davej@redhat.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gx-suspmod: fix "&& 0xff" typo
Message-ID: <20061108221106.GG3309@redhat.com>
Mail-Followup-To: Dave Jones <davej@redhat.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
References: <20061108220435.GA4972@martell.zuzino.mipt.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20061108220435.GA4972@martell.zuzino.mipt.ru>
User-Agent: Mutt/1.4.2.2i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1135
Lines: 30

On Thu, Nov 09, 2006 at 01:04:35AM +0300, Alexey Dobriyan wrote:
 > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
 > ---
 > 
 >  arch/i386/kernel/cpu/cpufreq/gx-suspmod.c |    2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)
 > 
 > --- a/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
 > +++ b/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
 > @@ -473,7 +473,7 @@ static int __init cpufreq_gx_init(void)
 >  	pci_read_config_byte(params->cs55x0, PCI_MODON, &(params->on_duration));
 >  	pci_read_config_byte(params->cs55x0, PCI_MODOFF, &(params->off_duration));
 >          pci_read_config_dword(params->cs55x0, PCI_CLASS_REVISION, &class_rev);
 > -	params->pci_rev = class_rev && 0xff;
 > +	params->pci_rev = class_rev & 0xff;
 >  
 >  	if ((ret = cpufreq_register_driver(&gx_suspmod_driver))) {
 >  		kfree(params);

Ouch, good catch. applied.

		Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/