Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp875045pxj; Wed, 16 Jun 2021 16:02:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZXMyHekV9EtMppVgPF48cvpz0zdGslamfoZJsCFN6d7h8djmFk2GRHCKLMRw9R5Lkmxl2 X-Received: by 2002:a92:c503:: with SMTP id r3mr1402770ilg.4.1623884557224; Wed, 16 Jun 2021 16:02:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623884557; cv=none; d=google.com; s=arc-20160816; b=CzRun+24ZRjl7jgIiIaAqHVSvBYTRehUHBAqUnbO8mnaiOQxG8zvXv+pmgabOBTyrX bb9ThE+8DfuOAGQXvrjmYFC4uqaKMpkponA8+mdvWTow5mC7zZkb3iYOR2aA9Ts2uSGt hUQGAKodljpHkPaiL2Ay9OfW6RPXlWBvgcFJoG47GX2A/FptjOGOclYy8TcHkF8fRSLZ cYfWqGbpBl+xgoKHpBIGfKLFMunbd0COu9+6CdXk7V9Z4MSiV03C+Gk+goyKT5m/quUc 3yIHh5XiFiwU35UkBIdz6KwLL6mDwIiHTpZyo9Imo0MiMK6F97wYNY/31trBt70vkvtn bDuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1WCOO+qvuEkTHaeUb4Py6PjcWDQjrWYWjrGCaK9VuNM=; b=tg0BoRP6ivIw7p28C0m6cqlngWJFe/hZZ79o1/XQ0z9D7rpGbh81/NuwYeuD9ccbLe jublQf08H8/c5gxJMkRziZnxyVCmUHuCXeisznTTyM/k1s6mCuK2S5QFILxKuiIVXNVP IddLKeb7DpqN9jGZyiNwRgkU/kEXCDKgdKMAAykpT11NwvxMjqPxYW9V08Uk3h94Q1w/ v6YClquiPVCZ3sCVQ/WbT6a7Cl+4OhlbqMzH60YJjmiT6Rza2FbAU88kTL5Iw4KZXQYW P9Vy7MMa8rMUBMXZ6097b+fzOueG/bhUru1EeCiOikAnN/TQMwFDRp1yVJaTIwfxjL+J /Tbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=tXnWJ5ky; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g15si3392823iln.71.2021.06.16.16.02.25; Wed, 16 Jun 2021 16:02:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=tXnWJ5ky; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235362AbhFPPlc (ORCPT + 99 others); Wed, 16 Jun 2021 11:41:32 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:45477 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234737AbhFPPjX (ORCPT ); Wed, 16 Jun 2021 11:39:23 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 31C9D5C0045; Wed, 16 Jun 2021 11:37:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 16 Jun 2021 11:37:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=1WCOO+ qvuEkTHaeUb4Py6PjcWDQjrWYWjrGCaK9VuNM=; b=tXnWJ5kyP0rT/238YVoGAh n/h/mPdHAlU4ZWSVUWc9LuJ+6K8dWFgKN17IMQqeio3eXAJydzZ3umfzAaV+YMCa V1IE0Qx1PfowsSe162zoFKVUGGX37wuME+jX2YjAhLW/kWDXXamoeDgFs9XOUbRH VZW9bu+M+k0v9i6oI8ZwB6Ftk8tOcPsikfN3dVkw4i8bpUXo5dAzK3nlsgMsbNjT rc3owkdNLAAaWEN/TtKL4EQ58RMKsE7QFaiqzlPDWuYm8iCZp3WWl/As4CcpeenJ siZYO7gpWEmlBiKSyIwW1+PKHYAM3tBTYoJVkNyy1wXA0OBw3paAGqCfMcQhI71g == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedvledgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtth gvrhhnpedtffekkeefudffveegueejffejhfetgfeuuefgvedtieehudeuueekhfduheel teenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehiug hoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 16 Jun 2021 11:37:15 -0400 (EDT) Date: Wed, 16 Jun 2021 18:37:11 +0300 From: Ido Schimmel To: Oleksandr Mazur Cc: jiri@nvidia.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vadym Kochan , andrew@lunn.ch, nikolay@nvidia.com Subject: Re: [PATCH net-next v2 3/7] drivers: net: netdevsim: add devlink trap_drop_counter_get implementation Message-ID: References: <20210614130118.20395-1-oleksandr.mazur@plvision.eu> <20210614130118.20395-4-oleksandr.mazur@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614130118.20395-4-oleksandr.mazur@plvision.eu> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2021 at 04:01:14PM +0300, Oleksandr Mazur wrote: > + debugfs_create_bool("fail_trap_counter_get", 0600, The test is doing: echo "y"> $DEBUGFS_DIR/fail_trap_drop_counter_get And fails with: ./devlink_trap.sh: line 169: /sys/kernel/debug/netdevsim/netdevsim1337//fail_trap_drop_counter_get: Permission denied Please fix netdevsim to instantiate the correct file and avoid submitting new tests without running them first. > + nsim_dev->ddir, > + &nsim_dev->fail_trap_counter_get); > nsim_udp_tunnels_debugfs_create(nsim_dev); > return 0;