Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp891232pxj; Wed, 16 Jun 2021 16:27:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuML6osOqWY9WUaDsRKPvJKicc6gHG/2ZN1B7MHy9v95cKp9T5L/RD+1mz6hO2yJk3bp/9 X-Received: by 2002:a05:6402:22fa:: with SMTP id dn26mr2602774edb.230.1623886037586; Wed, 16 Jun 2021 16:27:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623886037; cv=none; d=google.com; s=arc-20160816; b=bsHbU3k2F5k7uG6Am7Yy913AtU7WPcro08Uoo7asZMqHVh2EKQXGhW3A14iki6TwkD jzDKbyjIlrYS2YVg/SjtWoXu7mtMGB51oLDWRdzgMKDC5vTp7PEA12vvGGMuyWjUCQtu yduPLml+GEJy0jOi2huXzDsEZYZBBw+eP05kQCiU+VO9riuL3cQH7veMywgkSoxBU0kY jvCR5RKcUS6v7elt1NVVLXWIQsTvpbYWfHtDHko6/NUlgtqkwCL9tJXkjn6BG76OSHtB D8tNrTb3OIFTB0r1APqqp6qeA67XpG6M4/J2btSh7SKoOqH0dz/Rkxh4A4j6kE04555i Vkog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :to:subject:dkim-signature; bh=GoxvotL3Me0AkkYlw0Ff9VWdCGCouBv8obyOROpBU3s=; b=ovkQo0qNGYmE3S2pIsK/htNVvxyoUocpXvsm5DmhFeW4QJGf4bOsjsEZXpVhC2BQdT 7VeJEb3Yi9jaADMUYFpZ7Z6LMux55m4v47ahnWHZd62IFf7skTwYgbglxKEdamjJWFF2 WiLRzDiysZeGWgxrqBZ+aiYDGiD/rlHFzQPtaVO349vXj6bbiBDhiA9+Yn3Q7zWNqevC uPuYGIgLzxe43UcqOUBNqcmqAyAQ17Lm3daaYX+oCGV0vH+pONavV/EobqduvwMYCSPy yvO8aszXl+gZedZSF93EvLzn66/BEMvlbID1wD23K1lfISvjg29s70Nl19h0ktI16xQl cmHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JIHONi71; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ka15si3766071ejc.148.2021.06.16.16.26.54; Wed, 16 Jun 2021 16:27:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JIHONi71; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235707AbhFPPqh (ORCPT + 99 others); Wed, 16 Jun 2021 11:46:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235898AbhFPPo2 (ORCPT ); Wed, 16 Jun 2021 11:44:28 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A08FEC06175F; Wed, 16 Jun 2021 08:38:04 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id c9so3201738wrt.5; Wed, 16 Jun 2021 08:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=GoxvotL3Me0AkkYlw0Ff9VWdCGCouBv8obyOROpBU3s=; b=JIHONi71Nj48KGtkEH/NRy6iWWByc6oMka1xJsStJInEQUoJ+mZUfmOhZL9L6/tjru RC1la52iSscfXcUHtOSBwWZPk6C/xcjpZadLT1ckoZU3pFhWr3GYFImkYBpUAy/9Wmn7 TcHPTWaSrFmflG6GpolFXsbO/rFiiZFUbvIbbv+lodYA0vjCcDfpxjIMneHHdYE6UmvN IpC8cuTQcS1ppiZ1Xpuw+7xee9B0UN29FLOfFpledRhRZcpAb8Y9AuJEcHcg+gl6+EpB KREvwdWPrYKpvokS6lDbIKLjOb7xP8kIcfbKMuvG/Rsz4UYxZpm+wY0PUvgZcdoQrFfi wQWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GoxvotL3Me0AkkYlw0Ff9VWdCGCouBv8obyOROpBU3s=; b=YxcXXrAE0Dhifl7aO1MarbGijpawIRGXfzQvIoNMqq23IxKwcWQ+Xqoh0K1qpDYuli jeAHKnl/NOcNUGr7WWJl1v0Y7qSwlugjTA7D4ab/g+sRZvyabybI6vtUEUgfr4+W1Emm Vp+3thOQP8RKgd9aAl4HCId5nWpRegIfTWJj47JATShAr3u2W8PXAzvnrl9Bl6QO+5eM 1lpQcDM8zS/SOb2A/VSR8+IqNwnFVeiG6kv2FR6Cji1qLiW0YqCPlruy+LhXJNOMGDeb FZvI3BHYqT6dZSkqcFmgaUA5SzFlkf8lT7VucPHWuxggwCAaTQXffutNQ9Px85qmL57/ vslQ== X-Gm-Message-State: AOAM530b/HWDJHJL1heLMsfk5nLLFf9nDAwLEA1A8S5ASGouSzpYoaXX jiCUpGgBG4BSzphu6FC8Af4Qz1Gl9PjsTg== X-Received: by 2002:a5d:6e04:: with SMTP id h4mr25575wrz.256.1623857883112; Wed, 16 Jun 2021 08:38:03 -0700 (PDT) Received: from [192.168.8.197] ([148.252.128.74]) by smtp.gmail.com with ESMTPSA id c20sm2098396wml.37.2021.06.16.08.38.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 08:38:02 -0700 (PDT) Subject: Re: [PATCH] io_uring: store back buffer in case of failure To: Jens Axboe , Olivier Langlois , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <60c83c12.1c69fb81.e3bea.0806SMTPIN_ADDED_MISSING@mx.google.com> <93256513-08d8-5b15-aa98-c1e83af60b54@gmail.com> <4f32f06306eac4dd7780ed28c06815e3d15b43ad.camel@trillion01.com> <6bf916b4-ba6f-c401-9e8b-341f9a7b88f7@kernel.dk> From: Pavel Begunkov Message-ID: <5007a641-23cf-195d-87ee-de193e19dc20@gmail.com> Date: Wed, 16 Jun 2021 16:37:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <6bf916b4-ba6f-c401-9e8b-341f9a7b88f7@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/16/21 3:44 PM, Jens Axboe wrote: > On 6/16/21 8:01 AM, Pavel Begunkov wrote: >> On 6/16/21 2:42 PM, Olivier Langlois wrote: >>> On Tue, 2021-06-15 at 15:51 -0600, Jens Axboe wrote: >>>> Ditto for this one, don't see it in my email nor on the list. >>>> >>> I can resend you a private copy of this one but as Pavel pointed out, >>> it contains fatal flaws. >>> >>> So unless someone can tell me that the idea is interesting and has >>> potential and can give me some a hint or 2 about how to address the >>> challenges to fix the current flaws, it is pretty much a show stopper >>> to me and I think that I am going to let it go... >> >> It'd need to go through some other context, e.g. task context. >> task_work_add() + custom handler would work, either buf-select >> synchronisation can be reworked, but both would rather be >> bulky and not great. > > Indeed - that'd solve both the passing around of locking state which > I really don't like, and make it much simpler. Just use task work for > the re-insert, and you can grab the ring lock unconditionally from > there. Hmm, it might be much simpler than I thought if we allocate a separate struct callback_head, i.e. task_work, queued it with exactly task_work_add() but not io_req_task_work_add(), and continue with the request handler. -- Pavel Begunkov