Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Anand Khoje <anand.a.khoje@oracle.com>
To:     linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     dledford@redhat.com, jgg@ziepe.ca, haakon.bugge@oracle.com,
        leon@kernel.org
Subject: [PATCH v5 for-next 0/3] IB/core: Obtaining subnet_prefix from cache in
Date:   Wed, 16 Jun 2021 21:15:06 +0530
Message-Id: <20210616154509.1047-1-anand.a.khoje@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from AAKHOJE-T480.in.oracle.com (182.70.80.33) by SG2PR06CA0129.apcprd06.prod.outlook.com (2603:1096:1:1d::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.16 via Frontend Transport; Wed, 16 Jun 2021 15:45:24 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e58c72a2-0cf6-49a7-9f16-08d930ddc310
X-MS-TrafficTypeDiagnostic: DM6PR10MB3754:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR10MB3754410AB0D86D4E0F694153C50F9@DM6PR10MB3754.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: GE3ZrPg7HqOSvvaCUkJxNiiXlFecSQzBhWH+WmfaiIjB0QiTWSV+PXgkG7bTezi9sVQXUMVUzuiR11FK/jdPBQuhq3Blgn7S5jx2Aa11OvCte479De9LkxenVkGpypzh0b+7n+N9+elADP4lIKw5tOT1zcOjYOm6czmAuawlyMxdy+ao/3d80EkOvwdgnUCRyXl27YttXJxsE1eybbnAGpt3MdhwPQD8dXYmmQp7rsI7QmROdPml0Dje3ZZWXG1UGxvg5i0UBEcKSqucyaaS4k5cWRmF8m5C+TBHsY7VKvP/X5b3VtzqIqaFkc3OcgapQk+nfv2Tx1hSFZG45rcF5PdrgsUC6YHecn8JBwpZXcgDLyjpqHKlGiiYHC09dWkCIBFib7jPJENW19d+DlIwK3qR+TfRRAVoR0iQfO+VONIiRrhrQ9OpbEJHFNS5NZbW/1Z6cgs+K6IU38i01c0Y0q5Ikj8BEdDS/MTPGgpcbgijaillL3qjhqD8XgF0R3A5TlwlQjQ1Sa714cTHE7+TvEE46eUYfCAOibnt+GVZtFMZCY38w7w1lDgsY3aSgn9UQ1EmyNwbPIlWJ6/R8sHmEdnmWBpNzzH6YArADKRqnNTwwbcy0AtitnpQynEp86YtnVcJd4M35z1+wQCshXqvHxZd4Pk/uSpXWEvZVx4pmWYzFWydz84Ev77hX4e4rdU2
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR1001MB2091.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(346002)(376002)(366004)(136003)(396003)(2906002)(38350700002)(86362001)(6486002)(38100700002)(8676002)(186003)(26005)(66556008)(316002)(6666004)(5660300002)(16526019)(4326008)(2616005)(103116003)(1076003)(52116002)(956004)(7696005)(66946007)(478600001)(83380400001)(8936002)(36756003)(66476007)(120606002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: +33BSh4UfsMFku4rLh018hzoEOeZ02z2ad4Q8isC8ovUbMvajzNzEBxdx9SA3PibwqYgs0Bid9aLQJYpGuvU6JaFUr4vgzyzeicoaT1PBwuHXJmKNlnVKaUR0MX8N6Ro1xo2QEX5AtU7SlETxKlxw282dm1vOAgt5VZJKZs0uf+kknB6HdjzM3gKPVByJyjZUlb2P7KicVSpRy8VfxCEDzUgUnn+URlGqb8hYAaS2y/OQuj8BhR17CtkKJV7nYLCpUxqnc0ZrLEydFMMjQP8Ec+mNaeJOgAAEzgXwILvGLE+MMJlAE8tRtDLTNZ4pnIbBDzA0NwYsuTGICzM54CBu5o9LMO6/wwLyOhYC6TyGBo1ts91eXh6QDY9BsPyypykpRm4rc07mmcxVAoCkxZv/S9QF4gsX9Z+3b+20nhlAz1nhOi5cEKf8NvMRIgDBRUmvZ/2Wk/O3VQ3ZzOjnVIQQJVodJiO/0Fh6TvXRbcsUbfmMxIhs9ZN5WwqqxDomlszP49Ec60YHWq5xF1Sm0j77qwA2LP7vBZu+sn8arg/IINxx/IomqJJoAgABL+DgOIY0OLfWsYxjC7GE18qGUf6RPYlXgqJAhSv8nMkd2Zv3a+BuCbIlibgXOdXEE3mihhWFTgtvl51qW5huk5OaRR8mEXkRKbhcqaFmngwTlogoPLHv1/VCu94YMq7R8csUu4DAROgTTrudyYY5eJWVKsO+5dwu6aWMvy2Ui9IG61qyX4lJHyPHrpoNvul7OMR/O2I
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e58c72a2-0cf6-49a7-9f16-08d930ddc310
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1001MB2091.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2021 15:45:27.1376
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9Gvm5v6/lHbH61Q2stRwEWXxu5IAWbla4aTC9MrgRqRK1Um8VepJKtWFpXPaKUiRmxgs9ya6yesBAz+0vJby9SFFJCBa5v1XdYccre7kWgU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3754
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10016 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 mlxlogscore=999 spamscore=0 adultscore=0 bulkscore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2106160090
X-Proofpoint-GUID: NwKWXWpJvWaBCP1CzBrVY1KmxjQoqKCR
X-Proofpoint-ORIG-GUID: NwKWXWpJvWaBCP1CzBrVY1KmxjQoqKCR
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This v5 patch series is used to read the port_attribute subnet_prefix
from a valid cache entry instead of having to call
device->ops.query_gid() in Infiniband link-layer devices. This requires
addition of a flag used to check that the cache entry is initialized and
that a valid value is being read.

1. Removed the port validity check from ib_get_cached_subnet_prefix.
This check was not useful as the port_num is always valid.

2. Shuffled locks pkey_lost_lock and netdev_lock in struct ib_port_data.
This was done as output of pahole showed two 4-byte holes in the
structure ib_port_data after pkey_list_lock and netdev_lock. Moving
netdev_lock shaved off 8 bytes from the structure.

3. Added a flag to struct ib_port_data. This is used to validate the
status of cached subnet_prefix. This valid cache entry of subnet_prefix
is used in function __ib_query_port().
This allows the utilization of the cache entry and hence avoids a call
into device->ops.query_gid(). We also ensure that in the event of a
cache update, the value for subnet_prefix gets read from the newly updated
GID cache and not via ib_query_port(), so that we do not end up reading a
stale cache value.

Anand Khoje (3):
  IB/core: Removed port validity check from ib_get_cached_subnet_prefix
  IB/core: Shuffle locks in ib_port_data to save memory
  IB/core: Obtain subnet_prefix from cache in IB devices

 drivers/infiniband/core/cache.c     | 21 +++++++++++++--------
 drivers/infiniband/core/core_priv.h |  2 +-
 drivers/infiniband/core/device.c    | 20 +++++++++++---------
 drivers/infiniband/core/security.c  |  7 ++-----
 include/rdma/ib_cache.h             |  1 -
 include/rdma/ib_verbs.h             |  5 ++++-
 6 files changed, 31 insertions(+), 25 deletions(-)

-- 
1.8.3.1