Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Oleksandr Mazur <oleksandr.mazur@plvision.eu>
To:     Ido Schimmel <idosch@idosch.org>
CC:     "jiri@nvidia.com" <jiri@nvidia.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Vadym Kochan <vadym.kochan@plvision.eu>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "nikolay@nvidia.com" <nikolay@nvidia.com>
Subject: Re: [PATCH net-next v2 3/7] drivers: net: netdevsim: add devlink
 trap_drop_counter_get implementation
Thread-Topic: [PATCH net-next v2 3/7] drivers: net: netdevsim: add devlink
 trap_drop_counter_get implementation
Thread-Index: AQHXYR1pAn5iCi7wak6XE24VioxdxasWyLeAgAAB4Pk=
Date:   Wed, 16 Jun 2021 16:07:18 +0000
Message-ID: <AM0P190MB0738B2969624A9CDDCE53209E40F9@AM0P190MB0738.EURP190.PROD.OUTLOOK.COM>
References: <20210614130118.20395-1-oleksandr.mazur@plvision.eu>
 <20210614130118.20395-4-oleksandr.mazur@plvision.eu>,<YMoap5Vi6ZkXgKr3@shredder>
In-Reply-To: <YMoap5Vi6ZkXgKr3@shredder>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?+31vYz/yi9sx3p4N64gEu3yzI+0kWc9Erk0D3nCiGjpfKcm1GHruV1U/Gh?=
 =?iso-8859-1?Q?mNi46Ikz+eikHwLgIbCNNtOhEJ8pu9V8258czZJJ1xhIxYafzu4rnC6/ro?=
 =?iso-8859-1?Q?zTmGOzLIO59RKApbK5dRzDzFq8jrIy4LmlFZPQ1bgH7bws1CwRpyU6j9j3?=
 =?iso-8859-1?Q?xCwOFTg46FhNzM98c6GO0Qt7ofhaIWilyWqYD3UmPJPdLEWQivv14xmjoE?=
 =?iso-8859-1?Q?tBRN/JY7w4CU1uzjLHb7TROMbaEVHR4wSJ82+BgSWORVDMICb3v7Ai51ae?=
 =?iso-8859-1?Q?BHLKwWp6rojJRQIoQ1pv6GojYosk3StKbbUhdkjR5SOX82gEYLcYxvejbn?=
 =?iso-8859-1?Q?Gxm7NlJtLtTYhh6WEIgcop8PrHFp4TOponi1F4d6csYW9FHom8J0J2YfY8?=
 =?iso-8859-1?Q?gxe5bL7XK9rfUDWSio9TL3uozphVt99zMRB9MoOkYbpTRHtgXvpQjUGkW6?=
 =?iso-8859-1?Q?CWY7RydCYDGbrH18M1W6S1Yfuk0Iz3EzXyco92rcry4lsrL9usQxaNfhu9?=
 =?iso-8859-1?Q?lq2j1GRvUkumuio1dMkOUeCetixDH8T/fXBy5iQd1R9zjNoc5y8jFEJBhQ?=
 =?iso-8859-1?Q?5PT1oxGlod29JC8zqxaac2Atjs0S0ITm0UJ0elzEOs3VZvc2VMkPULeQEB?=
 =?iso-8859-1?Q?OJxGZ6b5WpZAdoBAvgoS9F9ybvPp0/vvDf2tv82sDklvEqMZZf8Lz8WPlI?=
 =?iso-8859-1?Q?G8WTZrFwi2G9lYXcsT1XIJmAx9V/MtDzwAgSS7nA28swe4lbk+oTfgdaG+?=
 =?iso-8859-1?Q?XYRtsEGCfo9QHQ6/2HlmeXXAlVrRhrIkEQwVBWcbDoSYNj9Tynpx28LDJ9?=
 =?iso-8859-1?Q?rwYNLLrPfZybva0ESR6ZxdOwLG8URXZoSSrboVH1DepEC8jykhBS1n7IJj?=
 =?iso-8859-1?Q?uRPMkKsja9JmmnPknx4yAHEARdYuspwGv+/Bhl5TK/7gWjTT1vdodaMwFZ?=
 =?iso-8859-1?Q?Fp7S3ec6CmVo2WAqfTceiSk/3Rjsnfl+iNrLHJGzBYAniWvQudfEKnfqUt?=
 =?iso-8859-1?Q?iHgpH28wnUetJZ0VqX6P5KPWibhCvTFJpUsjF8NitaMhjpeWZJ2pw8MeTm?=
 =?iso-8859-1?Q?6H4+e4K/VTlBf3uhuiZqrT6ccU72flksWdXpvSzrPjAf+aojeTOq86G/BX?=
 =?iso-8859-1?Q?SqxcBCjoX0BSge/6t7tjLWz90QR8oFWOGq4LRQnEQVs8gSFWe4DfNNTtHV?=
 =?iso-8859-1?Q?ES0U5VXAsHidsdlmH2yHqYXFN1L+P5AOw825gMiSVg7gYhuHYkcGdJXWW/?=
 =?iso-8859-1?Q?f2wyBNhV/Yi7tunRHnlW1ofgGIOFvRnQrjfwk3KnXc7cgB5TNZr+pvWGaw?=
 =?iso-8859-1?Q?yjxucnsCzw5QPlHq00aCUPr1VeN2s6Y9WiYIW5dAm1Iav8I=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0P190MB0738.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d3225e0-64da-4150-b8b7-08d930e0d133
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2021 16:07:18.9036
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dzUwHDdAz0aHBGUqkf2CCgLELQlDw/sC8OBAAz93t5kaMhDcYpq8YM1d2eAhIw1zw2sFbzSJXaF5EbtyjHp56mYsxiGlDhP8BdhgrCVU0dc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9P190MB1233
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Subject: Re: [PATCH net-next v2 3/7] drivers: net: netdevsim: add devlink t=
rap_drop_counter_get implementation =0A=
=A0=0A=
> On Mon, Jun 14, 2021 at 04:01:14PM +0300, Oleksandr Mazur wrote:=0A=
 > +=A0=A0=A0=A0 debugfs_create_bool("fail_trap_counter_get", 0600,=0A=
=0A=
> The test is doing:=0A=
=0A=
> echo "y"> $DEBUGFS_DIR/fail_trap_drop_counter_get=0A=
=0A=
> And fails with:=0A=
=0A=
> ./devlink_trap.sh: line 169: /sys/kernel/debug/netdevsim/netdevsim1337//f=
ail_trap_drop_counter_get: Permission denied=0A=
=0A=
> Please fix netdevsim to instantiate the correct file and avoid submitting=
 new tests without running them first.=0A=
=0A=
Sorry for that. I've actually run the test, but the problem is during patch=
 preparation the naming convention for the counter itself changed (and i've=
 missed the debugfs file name to get changed as well), and i've run the tes=
t before it was changed.=0A=
I will send the fix, thank you.=0A=