Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp905313pxj; Wed, 16 Jun 2021 16:52:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhhBN0eoSiQvCmVijQ8V4MYg24WuhCm83B/omlCLG3a0+kbMJtqv8CeWY4FoHiw5jTm+ov X-Received: by 2002:a50:fe8d:: with SMTP id d13mr2748440edt.14.1623887542650; Wed, 16 Jun 2021 16:52:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623887542; cv=none; d=google.com; s=arc-20160816; b=Q84tNhCZKUqePoDqz8AG5IkiNb3TG8C9vIciIupFSq15MsSLco9Rf/rfXY3IRwhnRd jndigjXpR3wDy/ddAQOjWFTg3rJZoTAxZ3GKE5eUNUEmmizQIIdyH70jSfst/1+djeh8 AQWt14y9YmWejqYMBoSxRiveV5dAp6AKtX8LvB/zx+PR17SAMPOJjtkbD5vCmfJfTCAG zUWthf+5KmtZX5wiw9ecTVp+yj47GAVcNJUM80Bcj7vz77mX7K+flEQ72UacnLK2etal hacMi0ATiIhVIgsszzMshcb6QwyS2HfDfMpZURIFh350Ti27x850P7ouhrBCT27/OmBO mQcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vSj9Cw2sZFxnc9sBK2ngjmm4yp0EI6eDCnwHta6M3PY=; b=ai4WEZceaPDic6heY0Efkv959NChvGdpl7GBM/ZI1myG+g58Nn/wzRaArUn+u8IOFI nRuN8uSZSreNz3d0zfUJEcci7j//cJ3zrqCLoevNXCbUONVn6F7INKAQO6w72sGMrykg 8Gaa3tFsrl2jNP2HrqyagLIfjZwGld4oUhFh9OfiSq0PNlUdpvfiRWYCCeJu0nEHQqWp kYjnfWvRGTmjxRkoeb5nN+1iPSW5nZ8EOjaOlvUQlDyBIyAs20bYg8S/uBKnef6oHwxS nriapWvlVoe6JGevVGeQDEjFdSeLK8rS9ibXCG85dvAG8aypCixXyW7Dv1i4XF15/b8l XyMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=dN1d0Oag; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f21si779838edf.112.2021.06.16.16.52.00; Wed, 16 Jun 2021 16:52:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=dN1d0Oag; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234699AbhFPQWX (ORCPT + 99 others); Wed, 16 Jun 2021 12:22:23 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40874 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbhFPQWW (ORCPT ); Wed, 16 Jun 2021 12:22:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=vSj9Cw2sZFxnc9sBK2ngjmm4yp0EI6eDCnwHta6M3PY=; b=dN1d0OagilH+uvDgQKP38uz0wk /VkYnzhrn/4sLpCWNIK8qF53+lspPV0cME3/45rNmH1x0KuXITIvZ54jIbA3i0f4bC1miLaduZdCt 1EgEJRewLEYuDcQC7/H7ZetOFAFmBgoZwPAk8myCPjb2ekJzMULjNyMDecLxhViupXRU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ltYGt-009knE-3W; Wed, 16 Jun 2021 18:20:07 +0200 Date: Wed, 16 Jun 2021 18:20:07 +0200 From: Andrew Lunn To: Guangbin Huang Cc: davem@davemloft.net, kuba@kernel.org, xie.he.0141@gmail.com, ms@dev.tdt.de, willemb@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lipeng321@huawei.com Subject: Re: [PATCH net-next 5/8] net: hdlc_ppp: fix the comments style issue Message-ID: References: <1623836037-26812-1-git-send-email-huangguangbin2@huawei.com> <1623836037-26812-6-git-send-email-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623836037-26812-6-git-send-email-huangguangbin2@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > static int cp_table[EVENTS][STATES] = { > /* CLOSED STOPPED STOPPING REQ_SENT ACK_RECV ACK_SENT OPENED > - 0 1 2 3 4 5 6 */ > + * 0 1 2 3 4 5 6 > + */ > {IRC|SCR|3, INV , INV , INV , INV , INV , INV }, /* START */ > { INV , 0 , 0 , 0 , 0 , 0 , 0 }, /* STOP */ > { INV , INV ,STR|2, SCR|3 ,SCR|3, SCR|5 , INV }, /* TO+ */ This probably reduces the readability of the code. So i would not make this change. Please remember these are only guidelines. Please don't blindly make changes, or change it because some bot says so. Check that it actually makes sense and the code is better afterwards. Andrew