Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Oo+CyOqD0/Ee27Vl0fK5Bxsp+DiGLzCDTQ2FMiUmE0Hy45LnGPU66tez7sptgSY6lxw2o+QSoe
 2JlgmTGwoPEA==
IronPort-SDR: 0ZDQ3heCk7d8sWgkK+uJ75YifobXY8g1yDR4ju7fsak6k+xLccplvf54fuLBvYOgj0mCOCDeyd
 PIDyOh5vwbeg==
Date:   Thu, 17 Jun 2021 08:42:02 +0800
From:   kernel test robot <lkp@intel.com>
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux ACPI <linux-acpi@vger.kernel.org>
Cc:     kbuild-all@lists.01.org, LKML <linux-kernel@vger.kernel.org>,
        Hans de Goede <hdegoede@redhat.com>
Subject: [RFC PATCH] ACPI: scan: __acpi_device_add() can be static
Message-ID: <20210617004201.GA151976@f10223fe78f9>
References: <3070024.5fSG56mABF@kreacher>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3070024.5fSG56mABF@kreacher>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

drivers/acpi/scan.c:660:5: warning: symbol '__acpi_device_add' was not declared. Should it be static?

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 scan.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index be8b149244220..f30ab5a55a9a4 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -657,8 +657,8 @@ static int acpi_tie_acpi_dev(struct acpi_device *adev)
 	return 0;
 }
 
-int __acpi_device_add(struct acpi_device *device,
-		      void (*release)(struct device *))
+static int __acpi_device_add(struct acpi_device *device,
+			     void (*release)(struct device *))
 {
 	struct acpi_device_bus_id *acpi_device_bus_id;
 	int result;