Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Pu Lehui <pulehui@huawei.com>
To:     <keescook@chromium.org>, <anton@enomsg.org>, <ccross@android.com>,
        <tony.luck@intel.com>
CC:     <linux-kernel@vger.kernel.org>, <pulehui@huawei.com>,
        <zhangjinhao2@huawei.com>
Subject: [PATCH -next] pstore/blk: Fix return value check in pstore_blk_init()
Date:   Thu, 17 Jun 2021 08:54:24 +0800
Message-ID: <20210617005424.182305-1-pulehui@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Fix the return value check which testing the wrong variable
in pstore_blk_init().

Signed-off-by: Pu Lehui <pulehui@huawei.com>
---
 fs/pstore/blk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/pstore/blk.c b/fs/pstore/blk.c
index ccfb11ee4d50..d5e22e6209a6 100644
--- a/fs/pstore/blk.c
+++ b/fs/pstore/blk.c
@@ -287,7 +287,7 @@ static int __init pstore_blk_init(void)
 		struct pstore_device_info *best_effort_dev;
 
 		best_effort_dev = kzalloc(sizeof(*best_effort_dev), GFP_KERNEL);
-		if (!best_effort) {
+		if (!best_effort_dev) {
 			ret = -ENOMEM;
 			goto unlock;
 		}
-- 
2.17.1