Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Jun 2021 09:13:52 +0800
Message-ID: <871r91gunj.wl-chenli@uniontech.com>
From:   Chen Li <chenli@uniontech.com>
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] ramfs: skip mknod if inode already =?GB2312?B?ZXhp?=
 =?GB2312?B?c3RzLqG+x+vXotLio6zTyrz+08l2aXJvQGZ0cC5saW51eC5vcmcudWu0+rei?=
 =?GB2312?B?ob8=?=
In-Reply-To: <YMnrutsyVKD4Ar2z@zeniv-ca.linux.org.uk>
References: <874kdyh65j.wl-chenli@uniontech.com>
        <YMnrutsyVKD4Ar2z@zeniv-ca.linux.org.uk>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0
 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 16 Jun 2021 20:16:58 +0800,
Al Viro wrote:
> 
> On Wed, Jun 16, 2021 at 10:53:12AM +0800, Chen Li wrote:
> > 
> > It's possible we try to mknod a dentry, which have
> > already bound to an inode, just skip it.
> 
> Caller should have checked may_create(), which includes EEXIST handling.
> NAKed-by: Al Viro <viro@zeniv.linux.org.uk>

Don't know may_create before, thanks!
> 
> Incidentally, if it ever had been called that way, your variant would
> leak inode.  Not the main problem, though...
> 
>