Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Nelson Costa <Nelson.Costa@synopsys.com>
To:     Rob Herring <robh@kernel.org>
CC:     "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Jose Abreu <Jose.Abreu@synopsys.com>
Subject: RE: [PATCH 2/9] dt-bindings: media: Document Synopsys DesignWare HDMI
 RX
Thread-Topic: [PATCH 2/9] dt-bindings: media: Document Synopsys DesignWare
 HDMI RX
Thread-Index: AQHXV6Hh6CGv0WSVIkW1H4BHlDvfK6sV0HgAgAEoHSA=
Date:   Wed, 16 Jun 2021 18:21:52 +0000
Message-ID: <MW3PR12MB445976E9C6911650D545C9D7C10F9@MW3PR12MB4459.namprd12.prod.outlook.com>
References: <cover.1622631488.git.nelson.costa@synopsys.com>
 <a5a52c738db7a4b3125225ac27e5aaff19604aec.1622631488.git.nelson.costa@synopsys.com>
 <20210615234048.GA1668783@robh.at.kernel.org>
In-Reply-To: <20210615234048.GA1668783@robh.at.kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?k+li0hohmRV9YRVUIj1C6TmHC+xDTWM9AZNKQ1k8OgaPPgR7z8rL8q7djqHT?=
 =?us-ascii?Q?LYFK6acc8zZeNb5dGpfRnDVwWVmIhMq4/wNvI3b0b5OOQbHfOIsPCSBn6+al?=
 =?us-ascii?Q?Z3sLSoe+qJBgVPfJcgLLnM3jb3ZVx7aJaPyIL7R16G1XErgwNMQIfwsoOPu/?=
 =?us-ascii?Q?7neQ8t742kbpxq9enOe4ngvS7xbOmMsIRUJJ/OOiNuumrTYmDdwxOdbfZIEu?=
 =?us-ascii?Q?4htTMDF0oipymZ26PkTjMjUtSI4pc3Vg3dpirf0oUFlip7M4x/yzTAfkva0X?=
 =?us-ascii?Q?p7XV/rbQJuRxNK9OpUdWgGYReE3294EDppxnCUjk4x0QB+DdOXws+DU6YvEY?=
 =?us-ascii?Q?Tu0Uv3WXAETsslhpEir5iVUCCxiYpZKLDBAo1HIwZQxfEAxqf9HSV6Mpn3wK?=
 =?us-ascii?Q?hexgY+9K2L3lkXmAnJDveixioFiYTcgICzWs6aRqStB9GSWyCc0Fpn+Ziv9s?=
 =?us-ascii?Q?9pnSiZCaKci4oolIa537Qpfh8+hbctJ0vIRFhKzm0nZY4ETnXanDi/68NTm2?=
 =?us-ascii?Q?CYk8vxeQWKA8klVAfDvSWJfGci0fqor9uVqW8uc0mtYNIyVUszfDbre9w+gh?=
 =?us-ascii?Q?KtQHLFDHtBfF9dzP81UWKgmJV76KgpwteBjucR0WKxoPMdGpOw+pTHMCjfbM?=
 =?us-ascii?Q?KlEvfXx0f3vjM7+cl9DspvVbC3X/VpijtAzKHE+4sz535hrbwlLxFDLfknX2?=
 =?us-ascii?Q?jqhrOqKSuoO+wK7LrTHUmjjoT1qzA5nZp+I80wsp2mH1LBiJf+Seusz90T+D?=
 =?us-ascii?Q?XvZJI2MzDYPDe6tRnVTRf0Nh2X8gk1Ziffhth1UkC0OCCfzmWjIoVVEwBJKD?=
 =?us-ascii?Q?Lks+wkCK6TvN1cfDU9bNHBilydOM0EFo1Ri9selFB53wI37URcr5So52P1+8?=
 =?us-ascii?Q?+ff+cK/W2WWmDdvGRhc66Nrt9MRZ3EvtinIi9E9Nr4uoxGG+oe3Qt3zGP7WE?=
 =?us-ascii?Q?oyXiP7W1u5Hs0TBO3EQTmINygFXsGIo9WX7EwqB8BvKJJbffYJjrJebsxQ9z?=
 =?us-ascii?Q?kIo1YBLSrA19NxakT995Q+j3mi+p4zdfZEHgd/47qvDhJ8bQWAA8R2wMfFeW?=
 =?us-ascii?Q?0dk0ooqOzIbocWfRzyYk4zAjwxH4aZ1kCP+K++mrgS3SaOim0E9eeG6YlHau?=
 =?us-ascii?Q?+2hOs3aeLzYAf4PR/3tXgMOjOkiTtWPrgOjDKfov70k2htWpkSu47JtMAgQw?=
 =?us-ascii?Q?ypoRK2txnGl5OSitPKkx1PaZrFADDStbD6XGE6pti3oYobYSQTUUmSsQxHpy?=
 =?us-ascii?Q?vBVyvp2um5MTjDw+QGTGPvDMt8lN83+CiFD0f9Pt6qf+vPothgXZDQOHcE22?=
 =?us-ascii?Q?vCM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: synopsys.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4459.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53320397-3a22-4f5e-b61a-08d930f39d95
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2021 18:21:52.6804
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NBK5tXBrWQeo7KG5aDEKu9jumOgRAtUXLCek2iYuzAW7isPS+jysQXcIWpWv1F4vHuhiJErZTaxKjAuKYRiHjQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0224
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

Thanks for your initial comments and feedback!

From: Rob Herring <robh@kernel.org>
Date: qua, jun 16, 2021 at 00:40:48

> On Wed, Jun 02, 2021 at 01:24:20PM +0200, Nelson Costa wrote:
> > Document the device tree bindings for the Synopsys DesignWare HDMI RX
> > Controller.
> >=20
> > Signed-off-by: Jose Abreu <jose.abreu@synopsys.com>
> > Signed-off-by: Nelson Costa <nelson.costa@synopsys.com>
> > ---
> >  .../devicetree/bindings/media/snps,dw-hdmi-rx.yaml | 98 ++++++++++++++=
++++++++
> >  1 file changed, 98 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/media/snps,dw-hdm=
i-rx.yaml
> >=20
> > diff --git a/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.ya=
ml b/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
> > new file mode 100644
> > index 0000000..4f2169e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
> > @@ -0,0 +1,98 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: https://urldefense.com/v3/__http://devicetree.org/schemas/media/s=
nps,dw-hdmi-rx.yaml*__;Iw!!A4F2R9G_pg!PXFG6mDuYYepSE77ynbfBUqpXfgW5g0UdVsjQ=
5p0CEVGkNknkcWScmrRWLFWmhWsFl4$=20
> > +$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schema=
s/core.yaml*__;Iw!!A4F2R9G_pg!PXFG6mDuYYepSE77ynbfBUqpXfgW5g0UdVsjQ5p0CEVGk=
NknkcWScmrRWLFWXz21yII$=20
> > +
> > +title: Synopsys DesignWare HDMI RX Controller Device Tree Bindings
> > +
> > +maintainers:
> > +  - Jose Abreu <jose.abreu@synopsys.com>
> > +  - Nelson Costa <nelson.costa@synopsys.com>
> > +
> > +description: |
> > +  The Synopsys DesignWare HDMI RX Controller and PHYs e405/e406 is an =
HDMI 2.0
> > +  Receiver solution that is able to decode video and audio.
> > +
> > +properties:
> > +  compatible:
> > +    const: snps,dw-hdmi-rx
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +    description: |
> > +      phandle to the configuration clock
> > +
> > +  clock-names:
> > +    const: cfg
> > +
> > +  phys:
> > +    maxItems: 1
> > +    description: |
> > +      phandle for the HDMI RX PHY
> > +
> > +  phy-names:
> > +    const: hdmi-phy
>=20
> You don't need *-names when there is only one generally.
>=20

But we are using the PHY API function "devm_phy_get(dw_dev->dev,=20
"hdmi-phy")" in the controller driver in order to get the reference for=20
the PHY.
And looking at the PHY API internal implementation (function "phy_get()"=20
that is called by "devm_phy_get()") seems that this 'phy-names' property=20
is required to get that PHY reference.

> > +
> > +  port:
> > +    $ref: /schemas/graph.yaml#/properties/port
> > +    description: |
> > +      Input port node, multiple endpoints describing the HDMI RX data =
connected
> > +      to the HDMI PHY receiver.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +  - clock-names
> > +  - phys
> > +  - phy-names
> > +  - port
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    hdmi_rx: hdmi-rx@0 {
> > +        compatible =3D "snps,dw-hdmi-rx";
> > +        reg =3D <0x0 0x10000>;
> > +        interrupts =3D <1 2>;
> > +
> > +        clocks =3D <&dw_hdmi_refclk>;
> > +        clock-names =3D "cfg";
> > +
> > +        phys =3D <&hdmi_e406_phy>;
> > +        phy-names =3D "hdmi-phy";
> > +
> > +        port {
> > +            #address-cells =3D <1>;
> > +            #size-cells =3D <0>;
> > +
> > +            hdmi_rx_0: endpoint@0 {
> > +                reg =3D <0>;
> > +                remote-endpoint =3D <&hdmi_e406_phy_0>;
> > +            };
>=20
> I don't get why you have a connection to the phy with 'phys' and OF=20
> graph? The connection should be to the remote device generating the HDMI=
=20
> data with a PHY being somewhat transparent to that data flow.
>=20

Would be possible to give an example for our specific use case?
Or there is any good example, similar to this use case, that we can take=20
a look?
Having in mind that we have two drivers one for the PHY e405/e406 and=20
other for the Controller HDMI RX and a device tree specified for each one=20
(patches [1/9] and [2/9]).

The pipeline is something like this:
HDMI Source (which is an external hot pluggable device) -> PHY e405/e406=20
-> CTRL HDMI RX

Thanks a lot,

BR,

Nelson Costa

> > +
> > +            hdmi_rx_1: endpoint@1 {
> > +                reg =3D <1>;
> > +                remote-endpoint =3D <&hdmi_e406_phy_1>;
> > +            };
> > +
> > +            hdmi_rx_2: endpoint@2 {
> > +                reg =3D <2>;
> > +                remote-endpoint =3D <&hdmi_e406_phy_2>;
> > +            };
> > +
> > +            hdmi_rx_3: endpoint@3 {
> > +                reg =3D <3>;
> > +                remote-endpoint =3D <&hdmi_e406_phy_3>;
> > +            };
> > +        };
> > +    };
> > --=20
> > 2.7.4