Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 16 Jun 2021 20:19:25 -0700
From:   Kees Cook <keescook@chromium.org>
To:     Pu Lehui <pulehui@huawei.com>
Cc:     anton@enomsg.org, ccross@android.com, tony.luck@intel.com,
        linux-kernel@vger.kernel.org, zhangjinhao2@huawei.com
Subject: Re: [PATCH -next] pstore/blk: Fix return value check in
 pstore_blk_init()
Message-ID: <202106162019.1766DA0@keescook>
References: <20210617005424.182305-1-pulehui@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210617005424.182305-1-pulehui@huawei.com>
Precedence: bulk

On Thu, Jun 17, 2021 at 08:54:24AM +0800, Pu Lehui wrote:
> Fix the return value check which testing the wrong variable
> in pstore_blk_init().
> 
> Signed-off-by: Pu Lehui <pulehui@huawei.com>
> ---
>  fs/pstore/blk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/pstore/blk.c b/fs/pstore/blk.c
> index ccfb11ee4d50..d5e22e6209a6 100644
> --- a/fs/pstore/blk.c
> +++ b/fs/pstore/blk.c
> @@ -287,7 +287,7 @@ static int __init pstore_blk_init(void)
>  		struct pstore_device_info *best_effort_dev;
>  
>  		best_effort_dev = kzalloc(sizeof(*best_effort_dev), GFP_KERNEL);
> -		if (!best_effort) {
> +		if (!best_effort_dev) {
>  			ret = -ENOMEM;
>  			goto unlock;
>  		}

Whoops; thanks!

-- 
Kees Cook