Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] opp: of: Allow lazy-linking of required-opps to non
 genpd
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Hsin-Yi Wang <hsinyi@chromium.org>,
        "Viresh Kumar )" <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
        Stephen Boyd <sboyd@kernel.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "andrew-sh . cheng" <andrew-sh.cheng@mediatek.com>
From:   Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
Message-ID: <9879b9c5-a5e6-425b-8184-868880f04f53@samsung.com>
Date:   Thu, 17 Jun 2021 13:27:13 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101
        Thunderbird/59.0
MIME-Version: 1.0
In-Reply-To: <20210617040027.vtqlhxqq7cwzeygg@vireshk-i7>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20210616053335.4181780-1-hsinyi@chromium.org>
        <CGME20210616075555epcas1p136129544501878b4bedaf8e46f9a43dc@epcas1p1.samsung.com>
        <20210616075548.ghp3lmjf4y6pyxoy@vireshk-i7>
        <b9310754-2105-2a93-ecbf-513d9a80a91a@samsung.com>
        <20210616090945.sn337tftdcp7y7y6@vireshk-i7>
        <742b2623-e8ff-db1f-9168-bdbde98110dd@samsung.com>
        <20210617033351.44pxdpjicm62byuh@vireshk-i7>
        <c40f535b-3075-62eb-3b82-837ad13d67d4@samsung.com>
        <20210617040027.vtqlhxqq7cwzeygg@vireshk-i7>
Precedence: bulk

On 6/17/21 1:00 PM, Viresh Kumar wrote:
> On 17-06-21, 13:09, Chanwoo Choi wrote:
>> On 6/17/21 12:33 PM, Viresh Kumar wrote:
>>> On 17-06-21, 10:13, Chanwoo Choi wrote:
>>>> The devfreq driver(exynos-bus.c) has used the dev_pm_opp_set_rate()
>>>> and used the passive governor without the required-opp property.
>>>
>>> Which is fine.
>>>
>>>> I have a plan to use the required-opp property
>>>> between devfreq drivers (exynos-bus.c) with dev_pm_opp_set_rate().
>>>>
>>>> I'll support them on later if this approach doesn't break the any
>>>> rule of required-opp property.
>>>
>>> You will be required to make some changes in core for that I am
>>> afraid. It won't work automatically.
>>
>> Do you think that better to use clk_enable/regulator_enable directly
>> instead of dev_pm_opp_set_rate() for using required-opp property?
> 
> No. All I am saying is that the OPP core won't work for your use case
> today and may need some updates.

OK. I'll update them for this case.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics