Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp123099pxj; Wed, 16 Jun 2021 22:10:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMDsByDdsXHbhA/8aw+JvM91GGYOg27muEI65TOGshQalX327F065p9KItHvwHs5tTslIQ X-Received: by 2002:a05:6402:520b:: with SMTP id s11mr3937543edd.111.1623906624374; Wed, 16 Jun 2021 22:10:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623906624; cv=none; d=google.com; s=arc-20160816; b=ufbymK5sXnV3neVKpfi8SIp65jW8Cq5A6ai2tvkBXJZ+eW4158D3BuRLazq5g1TF6I JPdV4Cf31zedPLB5Rpwh99IOvY4b5tb8eMv/dmhuub9gx27KyII9RU49VzVSSwrobhbX BRIia0jtsnOCkB/v1F/t2dy10Jjqf5CvZ0z1SimUYdtzClhJEkjvvWfVC4kC6ZCD2XBS TSM/L7sY9s7djCbVVHCrzqVjE62WoVkixRx/9qi2mTcun0mzgV5fW6K5RxjqNtYL1Su0 gkVFbXY60URP9//97VMA24VmYB+d0RbRFf/hek9jnZSRwwXRkyi9K8rD37D3EzqgJWSj RgPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=YzSwXt45pJ2EN/5MhJa9QMem06Lrvq8cT0lIw3fOsyc=; b=aK6Z6+0t83Xa+yBGB9zVofwZMkOzppd1o1WurCU6x9irZhprEQUw2yq8ALGakEX1+0 2FLUZlTiNdKb9yvRc0G8wPBKWJ2r2qSm3DhuKmvNF6CJyHh8sRxeimNtXBCmxd1lwbFl SBmK3mOlPP7tz7j4Ot3yak0xvkThLk/5WRl10ANRgXUvaRnp+LrcsWWKr6EE3JQIycQG 09fHBXct8JydxhKJuJJB7g19oYN1eXjtz3S1asHB3RqZM+/Qe7rS338ytON2QelzeEPO 2Tx175f5oZMG4gVJII0aiuRbA6UaRxyTqJvRq6HAIz9a35mcNdxTOiRNvxGYzvXW4hBX ukWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id go15si4343093ejc.608.2021.06.16.22.09.44; Wed, 16 Jun 2021 22:10:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229599AbhFQFJj (ORCPT + 99 others); Thu, 17 Jun 2021 01:09:39 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:11045 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbhFQFJh (ORCPT ); Thu, 17 Jun 2021 01:09:37 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G592l1qbYzZflX; Thu, 17 Jun 2021 13:04:31 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 17 Jun 2021 13:07:27 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 17 Jun 2021 13:07:26 +0800 From: Yang Yingliang To: , CC: , , Subject: [PATCH net-next] net: ipa: Add missing of_node_put() in ipa_firmware_load() Date: Thu, 17 Jun 2021 13:11:19 +0800 Message-ID: <20210617051119.1153120-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This node pointer is returned by of_parse_phandle() with refcount incremented in this function. of_node_put() on it before exiting this function. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/net/ipa/ipa_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c index 2243e3e5b7ea..f82130db32f6 100644 --- a/drivers/net/ipa/ipa_main.c +++ b/drivers/net/ipa/ipa_main.c @@ -530,6 +530,7 @@ static int ipa_firmware_load(struct device *dev) } ret = of_address_to_resource(node, 0, &res); + of_node_put(node); if (ret) { dev_err(dev, "error %d getting \"memory-region\" resource\n", ret); -- 2.25.1