Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp202142pxj; Thu, 17 Jun 2021 00:24:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFlWxjDsD9oPeG8mE3+mcM2SC0JMSomwPmAUIrchnIy2t01qYQeTK2Qohs9biZQTNkfKUr X-Received: by 2002:a92:3f11:: with SMTP id m17mr2355025ila.38.1623914689993; Thu, 17 Jun 2021 00:24:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623914689; cv=none; d=google.com; s=arc-20160816; b=F9QLiORjFZkhf0Rl0Sgmnex3WUHJwBbuZtApc6UN6zGAuuNWwpd5/2ANvl4n6/6CWc OstSqYzlUVEg4B+JoNNlvk9V94/9VexFCaOdgPH5VgXfFJfjhtxmW1oSph1tfcIIU9tD iGzrQQY78WslB1ODEVGbTR1fp4yaYro6rcmnMPEI9D4HHXa3dy/4LBBuWXd7EF8Pu84g HuTCNJOynUgGWbVnE2ou3pl0SgYm+XKavpmovdp25sC+KZRgVEZNehdkmAuJIwsCOV2c nPhgITenVEN/wItozEb/uWt8CqlshKWncTMOzVKrW/hqZVS7uRJKvVwldU+43n8170Jx YOIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=5EJHYl1yU7Pow/wnJj81H7UByJjr0qf/FtfK8aR+zlA=; b=iH5zPEuKZMF/xiGvCBNnVP5dSNF9JATDBIQjNCxPGMOVW296JxdAl9TKaP9gQRtKUH wS9DyyyuZnvNVC+oZqDWpM2a0CP76IHOEEuFi57AdnYorAtCCMgGoaQ7m+b7TlUfDwyB DIqw/Lb+fJAlpPxjX0hMqtBG7Fl8qGI1eUnQhw3EJKvSK+HTcqL1VKkPI3Fboeak1zgk mHcpo35uy6gqOLH8zFUF5oQkjasqqsN3jzB8ioLsolbNeOKWW8xG0blRAGqKhF4rA8j7 Rc8bqM+LqEaqYqtLbT5FFgWms0tIB4LLPLs2HrQ55O76w63CoO4Zf+aV9pGquSmqDVbb 3k3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s13si5234999jat.111.2021.06.17.00.24.38; Thu, 17 Jun 2021 00:24:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229891AbhFQH0T (ORCPT + 99 others); Thu, 17 Jun 2021 03:26:19 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:7317 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbhFQH0S (ORCPT ); Thu, 17 Jun 2021 03:26:18 -0400 Received: from dggeme764-chm.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4G5D2301Ptz1BNF1; Thu, 17 Jun 2021 15:19:07 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by dggeme764-chm.china.huawei.com (10.3.19.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 17 Jun 2021 15:24:08 +0800 From: Jing Xiangfeng To: , CC: , , Subject: [PATCH] usb: typec: Add the missed altmode_id_remove() in typec_register_altmode() Date: Thu, 17 Jun 2021 15:32:26 +0800 Message-ID: <20210617073226.47599-1-jingxiangfeng@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggeme764-chm.china.huawei.com (10.3.19.110) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org typec_register_altmode() misses to call altmode_id_remove() in an error path. Add the missed function call to fix it. Fixes: 8a37d87d72f0 ("usb: typec: Bus type for alternate modes") Signed-off-by: Jing Xiangfeng --- drivers/usb/typec/class.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c index b9429c9f65f6..aeef453aa658 100644 --- a/drivers/usb/typec/class.c +++ b/drivers/usb/typec/class.c @@ -517,8 +517,10 @@ typec_register_altmode(struct device *parent, int ret; alt = kzalloc(sizeof(*alt), GFP_KERNEL); - if (!alt) + if (!alt) { + altmode_id_remove(parent, id); return ERR_PTR(-ENOMEM); + } alt->adev.svid = desc->svid; alt->adev.mode = desc->mode; -- 2.26.0.106.g9fadedd