Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp237432pxj; Thu, 17 Jun 2021 01:22:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsljYaRc0u8fQ7n1/IqM8GekOxzgUnG9XHKWV3WJUu88iM15GLPPJ/PjYEPWuAb6CYiBkL X-Received: by 2002:a05:6e02:1246:: with SMTP id j6mr2730984ilq.30.1623918131914; Thu, 17 Jun 2021 01:22:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623918131; cv=none; d=google.com; s=arc-20160816; b=qE/HjhOyS4u02rBbpvi/99Uku9pq7FzhPdhJVFErBmGQ+yjXpMHibYMf5hnvqyT6Ob LBrZLXXYI88J+dlhpSVeAumJgtyikinlvtdhUVsq2lyzz1FnakqbRQBbLtW//XzR4j/5 +IN4aFYtpyMCWCHi0ucsKFt7QB+FHVaA5s5OkzCLDsWmTSkPSLy6VwDiFMos7a8kZHVC iHPPmzuLskk09GqC6UhqI5RuSaBzaM4tJBWl7Jl/icrf8aBQsOvkkmHcZ4CWNq8pYyGQ 6NZyat91CEOLehBYlpZI2+NHh7Dfm/NdxOaV1vG7iD09yPJjHZ2WiSUCmt02CN+mGWbp JhLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=cbx+euKbC7pUOUFJX8fVnmfL9og6wRNSoZ+8uoVLuNc=; b=Gx+DSwsO3sZiRfiRY7vUnMENgfiR3jDRzgSwpvj/3PJW+gvgizmFMQAG3lV1IieVTx xSGd8OG/TCH4iOc/e3uLufGiSKa4/TsPPx5mcLAkKfYhzybTBHgKakpm1kHKQt9bvKAB YAxwkutR2aAT/xKgkYMYLXtkzuQZ1E/WYtuh03Y7AXJQzSQYouy2sCwYFSKLBy43cRC6 jLvkOuqiEVBdzHXrJiSPiFIps31U7o/hTBgDxOgvA+DHvU7+t7TvrTE1Axm23Ez+q133 Z+fydmc56aw5P/cMEdDeBhSKWpoxgJXXOnM1KYSW9MTtmxDmkVjYahzVoVOI2GS/9LNI RV5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vSu2TqRQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h41si4902024jaa.50.2021.06.17.01.21.59; Thu, 17 Jun 2021 01:22:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vSu2TqRQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230391AbhFQIWY (ORCPT + 99 others); Thu, 17 Jun 2021 04:22:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229842AbhFQIWT (ORCPT ); Thu, 17 Jun 2021 04:22:19 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFA5AC061574; Thu, 17 Jun 2021 01:20:10 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id g20so8477308ejt.0; Thu, 17 Jun 2021 01:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cbx+euKbC7pUOUFJX8fVnmfL9og6wRNSoZ+8uoVLuNc=; b=vSu2TqRQlWulfmJEHmuSF8Cib4kDDcimF6HRxu6MrcUZjzVcRTPlhxPATXSsSOqjA+ sIL8ssPR7NhnrBsjvYAPjn2cBJs9JAkGwJ3sbreR8J0hXO4zHbkRMKu8LPPQfkM2WLpr SGBoGdQBFsL0CFqCDWaCs1ixQBVu/dIiGgfGoJsrZGfplHKrqLW4hQziPw8DUTFgLriT 03DILPl5dd08ZM6b9+TtemW8ziSMgC8diEQ4Rc255QlmDVs8mEKXpgTkMEGLarblvcwB gBWaM18olnHiRF95smz0bw1n9WJAeR4UYkQ1svp0+u0MHDDqyHlTq5mbElln7Ycl+B+l SAEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cbx+euKbC7pUOUFJX8fVnmfL9og6wRNSoZ+8uoVLuNc=; b=hMM3xJT0u79AhsBjKIQ6Z3Doe9QkJodg4ATIwDy9aNHJ0JtCMUWFkduJM545gIFAbp okikQEcLqBUUdDYrUQ3OQzxSvdJbUzHZsvysIwuIaXAk4CWQXe3LSbb/LQuYWEQlO3oq VdWmkQEJbUobXiV9izj1HSLMXGlNsUD3fMgR31allGRQRR1oT7nsGa8xT8Cl0soBOwbM 1LjfCZsbJrC8TeoilhUW+lnYp06iehiENKEeCLYp6yzgRHILVVrBGSlZOdvhrnltyFXz kamEQNp/EsGV4HU434JOZtpvEceOc/4DZoXF0H/+/E6XpHHiv0SB0NQBdUGVe0quMfLd q0rQ== X-Gm-Message-State: AOAM5314KCJ7XaZm/gUTsWS1fESZzknwdYo51iZx13w0xBnyu6OBxN5h CleOkfzup8LyP9bheb7eTKAaTb5+kEnfsOfUrPY= X-Received: by 2002:a17:907:1b1b:: with SMTP id mp27mr3901941ejc.538.1623918009568; Thu, 17 Jun 2021 01:20:09 -0700 (PDT) MIME-Version: 1.0 References: <20210512144743.039977287@linuxfoundation.org> <20210512144748.600206118@linuxfoundation.org> In-Reply-To: From: Amit Klein Date: Thu, 17 Jun 2021 11:19:58 +0300 Message-ID: Subject: Re: [PATCH 5.4 175/244] inet: use bigger hash table for IP ID generation To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Eric Dumazet , Willy Tarreau , "David S. Miller" , Sasha Levin Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I just sent a revised patch for 4.19. On Wed, Jun 16, 2021 at 5:57 PM Greg Kroah-Hartman wrote: > > On Wed, Jun 16, 2021 at 09:16:12AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Jun 16, 2021 at 10:02:44AM +0300, Amit Klein wrote: > > > Hi Greg et al. > > > > > > I see that you backported this patch (increasing the IP ID hash table size) > > > to the newer LTS branches more than a month ago. But I don't see that it > > > was backported to older LTS branches (4.19, 4.14, 4.9, 4.4). Is this > > > intentional? > > > > It applies cleanly to 4.19, but not the older ones. If you think it is > > needed there for those kernels, please provide a working backport that > > we can apply. > > It breaks the build on 4.19, which is why I didn't apply it there, so I > would need a working version for that tree as well. > > thanks, > > greg k-h