Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 29WV+KNJhblaxIevodIDadYEGGGcE/2jcGMR24q7J3o1QL4AEK20BlatEKxYEjdKCkzDQJLOvl
 7ABxA5VoCjqg==
IronPort-SDR: cnd2chz6DCp9kBa4Xwsk2+Gdw8hHqdEJI+s+2afcrCRCrz0/dOX+zsMcnbEIPEwsuA0lgApTLi
 00B5Q7IkGDug==
From:   "Wu, Hao" <hao.wu@intel.com>
To:     Moritz Fischer <mdf@kernel.org>
CC:     Tom Rix <trix@redhat.com>, "corbet@lwn.net" <corbet@lwn.net>,
        "michal.simek@xilinx.com" <michal.simek@xilinx.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "krzysztof.kozlowski@canonical.com" 
        <krzysztof.kozlowski@canonical.com>,
        "nava.manne@xilinx.com" <nava.manne@xilinx.com>,
        "Xu, Yilun" <yilun.xu@intel.com>,
        "davidgow@google.com" <davidgow@google.com>,
        "fpacheco@redhat.com" <fpacheco@redhat.com>,
        "Gong, Richard" <richard.gong@intel.com>,
        "luca@lucaceresoli.net" <luca@lucaceresoli.net>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v4 1/4] fpga: dfl: reorganize to subdir layout
Thread-Topic: [PATCH v4 1/4] fpga: dfl: reorganize to subdir layout
Thread-Index: AQHXYVpMuuq4CCKpI0OAe3HAOe9lxqsUps2ggADmEgCAAEctkIABz+UAgAA0T8A=
Date:   Thu, 17 Jun 2021 08:34:15 +0000
Message-ID: <DM6PR11MB381924F43550A6699CB55213850E9@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <20210614201648.3358206-1-trix@redhat.com>
 <20210614201648.3358206-3-trix@redhat.com>
 <DM6PR11MB381964374223D0D2958AFA6985309@DM6PR11MB3819.namprd11.prod.outlook.com>
 <d64b0fb8-5f83-2995-7ee9-b4ed2932ef60@redhat.com>
 <DM6PR11MB3819259241791EB04A2CB9C8850F9@DM6PR11MB3819.namprd11.prod.outlook.com>
 <YMrS9OUSaCdtGwrE@epycbox.lan>
In-Reply-To: <YMrS9OUSaCdtGwrE@epycbox.lan>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Lt7pYXZx8ymj+C3XZLCcDZ82vXEVshWrDXVIhngYvqYaxPZgqqUDHbPvGpYi?=
 =?us-ascii?Q?5ARVcv6dCaawwyhCEWWacXect5ZoDBIHdFN2MPa0LdkU504TI5TjywZpdFMU?=
 =?us-ascii?Q?9rqBqtrwtu+aqBIKlZNch/bmlIXdMZxDv1dCwS22yHbtMbtOUh1//pD+ToVH?=
 =?us-ascii?Q?eJx0ebc7D/ya6QfCCptYUlUPyJPLHMkw1KByPMXtJPKrfEr1fcTihJp0WUIl?=
 =?us-ascii?Q?j7oSNT/QYrwNo8d7H1a1MzDjp6SLqteSJRGfUaMhz2AYA2GVDBQIX/JHZQ/M?=
 =?us-ascii?Q?f6NoGauYUJlRAnDHD3Ig2zS2a9Pdsenxdf9PUfzmHB4ErwVQ+ZBcl9Kye7hI?=
 =?us-ascii?Q?+6ibZbpEj9H6hnGJtMyTOndSwVpqGfscI3xpnJY4rxGSJ7tucsf4+rPUp+vL?=
 =?us-ascii?Q?FAWRf2/Px3bIAciZSE5kIomJAoumb+1MmMnFTcOvFqR421OYIJ9fKbfzsn6B?=
 =?us-ascii?Q?9byqyIgEdzekAUZq9LiVGI9Qn7oASTBwFhj8V+3WUnPTNNnx+PYBL5mHpljI?=
 =?us-ascii?Q?KvixH1veFGnlltUeHv9lLsBMOAG8zPPmS1upZDCjVmWF3AHcCFhyKy/IPjs4?=
 =?us-ascii?Q?Hi+YtT7Hnl2+09nGqsTWlOz+TBFqH40xkSMR94JHazkP3v0FsEkI3p9n3aBo?=
 =?us-ascii?Q?QYlxYkGInw/iSPnx2C8zwXI6zYqbpNCJ9ValwAjFhR41Bz9n1opZ1pkMO+9j?=
 =?us-ascii?Q?kFSFhTBu1eV0A8M6o8SueZ512xwe/JW1rAXheGiQ8SYKfLUKRM2ayQ9U7Ae/?=
 =?us-ascii?Q?wu0naryEAutJYTyQ+RrZyhDESktWzsV/2jMHzNd4CD+qwYzxg81NgnvxQlYo?=
 =?us-ascii?Q?BhMV2uuXm7kDidR/UAcmcYz/YK4bKS3CQSfOAP0mPeYEnGgScm7cedswrSQE?=
 =?us-ascii?Q?tzYX/hCijiWmsThJnoiuPmPgAHKRFLqvh6dt5IYSMNrnehJjI9hDWnCfgJS9?=
 =?us-ascii?Q?03CMvOn0AzsfpgnHwxuZ4Hg27Kf2uuzKhW6lFzRLb5O8+DRXKxIOo8CD4Iwu?=
 =?us-ascii?Q?6YMJdoFYXumKvtC+VeZ9zOXnbjMnQcMrlc4ceKsj+b4s+ZA8BvUFo+JCPI5E?=
 =?us-ascii?Q?zROSzzkS4NNq2jOy/sf4tqNA8fk3rB7YJK9Xc/y2pfMwCjdUyYTJAdG6fkNI?=
 =?us-ascii?Q?ywlG4435UB2VYYWmh5BnRtNbtrnik4l7Yi/VoKjDuB1Y9p9bYyAj5p7FOSQe?=
 =?us-ascii?Q?ntrm1HbpjnTi7rrNjCajO8VKJKUbqjIMj49MfaF5XY0q2ec9Y9gh1M4BH50Q?=
 =?us-ascii?Q?08nTlw3TQ83RningKVeJC96TqW+2VRLyJO32J3XkjQlRZ++tYPfJHILa9O4D?=
 =?us-ascii?Q?wEFG1I4DcxhouvWTElTrg1e/?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3819.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 756587bf-43ca-4b0e-2014-08d9316ab0e4
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2021 08:34:15.2931
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wBFFquyL7qkFY7kDFojUPUPAxQl+SX3fJ6Z9HIaYq2vlOBhYblLI81TFoVuOFkz7toGQP/555DItx4KuR7EG7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3243
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Wed, Jun 16, 2021 at 01:05:36AM +0000, Wu, Hao wrote:
> > > On 6/15/21 1:08 AM, Wu, Hao wrote:
> > > >> Subject: [PATCH v4 1/4] fpga: dfl: reorganize to subdir layout
> > > >>
> > > >> From: Tom Rix <trix@redhat.com>
> > > >>
> > > >> Follow drivers/net/ethernet/ which has control configs
> > > >> NET_VENDOR_BLA that map to drivers/net/ethernet/bla
> > > >> Since fpgas do not have many vendors, drop the 'VENDOR' and use
> > > >> FPGA_BLA.
> > > > Hi Tom,
> > > >
> > > > Thanks for this patch. : )
> > > >
> > > > DFL is not a vendor, but something can be shared/reused. It's possi=
ble that
> > > > other vendors reuse the same concepts and the drivers of DFL. If ve=
ndor
> > > > drivers need to be moved inside sub folders, then maybe it's better=
 to
> > > > leave DFL in the parent folder?
> > >
> > > xrt is also not a vendor, more a subdevice framework like dfl.
> > >
> > > I am not sure what you mean by other dfl vendors can you give an exam=
ple ?
> >
> > It's fine, but the description here is a little confusing on vendor/fra=
mework
> > handling. No other vendor so far, but it's possible, DFL can be used in
> > non-intel device, and related drivers can be reused as well. Then a fpg=
a
> > mgr driver depends on DFL, should be put inside dfl folder or new
> > vendor's subfolder?
> >
> > Hao
> >
>=20
> I'm somewhat neutral on this. If someone non-intel starts using DFL we co=
uld
> also
> move the common parts back ...

That's fine.

>=20
> That being said, I'm not super convinced we have to move stuff in the
> first place.

I remember that the first submission of our code is having everything insid=
e a sub
folder, but was suggested that to have everything moved out, this is why we=
 have
dfl files here now. To be honest, I have the similar feeling as you, I didn=
't see any
strong reason to make this something we must do, but both solutions should =
be
fine. : )

Thanks
Hao

>=20
> - Moritz