Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp300431pxj; Thu, 17 Jun 2021 03:04:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmdhDnqPnlGcWqOIFevjN8r69+DmMy8UPzZWx+RhzJew3uns0gaqLXbCrvn0zwYqr2Bg2I X-Received: by 2002:a05:6638:13c3:: with SMTP id i3mr3788398jaj.140.1623924295553; Thu, 17 Jun 2021 03:04:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623924295; cv=none; d=google.com; s=arc-20160816; b=Ddi8Vl/Ea8MPjwQBct6P+vL5jafb050idg1hCh79+SSXSl+ksXwF2KYIMrhx+1BoiW yVZdfwBQJG4xSF+MVv4lGIe5flSyhXxoiwNuxuDhGpnHfjU0tHa5hdfS5hipRA2cDVra 2VbXRrkGR5h7dbos5yEexe4gJQ1I43hmZazNrAHT6g+EzJpqrXv4E63CqIPa3HQJJeSd 1yhR6d/UDNlOTWe2pP4eg2tEocElWhJDbOFGgIWeperD5sgNL55YG/Y37fM/cWC2tlFp 1d+mQPf/tchGxhAaEYnUOlnzqLIWemGgJrCbPX8CtBXgwYQKVTbYZ4JGE1vJnsitSas3 Qntg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0h+hHUgLPVMvuqj7e/pELmBGwK4EwC7AUnAaDhyPTxc=; b=c6mSdU+RikXiL/kf+i6ZMMoAvLvNNL+m0Oi//1i+hJRJ00X7XF8bw6L5CrF9CQS8v8 b28H7dTRVt/3DkWF8THkE16fAE4DR7dwsLScsjz2zbfFnIPfe4gGt3pt2kP0c7AVvote KddR2C8tsfug9iVqVK0C69nrzwO3bbQL1RYb6YjbfeqjsOkUH2Ox+lg/IhQR2sdEpJLH +XD1OZQO5eOMOxRih0u4/QWGJbcxbMtyCzWWlLterNTQrE/1M6X+motwrsS/rwf4Znzi EnO3nhwGfQcRkhG+bWGfI5JiOjn318RuW+pLkJN2GxPGMA2kq498GKhFUGmNohspCXtk 449Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@geanix.com header.s=first header.b=GnnqdQ5V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=geanix.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u12si6456746jat.20.2021.06.17.03.04.43; Thu, 17 Jun 2021 03:04:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@geanix.com header.s=first header.b=GnnqdQ5V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=geanix.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231867AbhFQJvd (ORCPT + 99 others); Thu, 17 Jun 2021 05:51:33 -0400 Received: from first.geanix.com ([116.203.34.67]:41918 "EHLO first.geanix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231873AbhFQJva (ORCPT ); Thu, 17 Jun 2021 05:51:30 -0400 Received: from localhost (unknown [185.17.218.86]) by first.geanix.com (Postfix) with ESMTPSA id 106774C325D; Thu, 17 Jun 2021 09:49:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=geanix.com; s=first; t=1623923361; bh=Uk5FCCq/1hvryiYQiavefB+WTK09cJgC9AtSy84qEt0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=GnnqdQ5V/UeL4MATP7d7kuaHLuKjFWGWmCX7OvdCB+Ed2c88XZ02kn9IIEDwEq4Jj dItGk5y35TPEhcibTjc85UQ2nG1bImQ96nikqRAcUn4iBEcQrx79IK5HgfDvgRMKm/ XIpCFGFRl9rQE7B4paV1KKTidbeIVA4uOSBTOe7kBO7CF+ZGXXZTAPgZ1sU7EQzo/j K9HdgolAGZZ8ulFj8pmxZXR0cvNVWwwe8xrrBM+2m4LF2uJdkJa53Icp9xpZ9WtNYr +w4vyJSNOQ25set5m5akPFMsB0F9/A2L/ssvf5d3RoTPQt1JK0G2/+KfoZYoLkn5XF 0oKYPjd63/SJQ== From: Esben Haabendal To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Rasmus Villemoes , Claudiu Manoil , "David S. Miller" , Jakub Kicinski Subject: [PATCH 3/6] net: gianfar: Clear CAR registers Date: Thu, 17 Jun 2021 11:49:20 +0200 Message-Id: X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=4.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on 93bd6fdb21b5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The CAR1 and CAR2 registers are W1C style registers, to the memset does not actually clear them. Signed-off-by: Esben Haabendal --- drivers/net/ethernet/freescale/gianfar.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index a0277fe8cc60..ebd1065f39fa 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -3103,6 +3103,9 @@ static void gfar_hw_init(struct gfar_private *priv) /* Mask off the CAM interrupts */ gfar_write(®s->rmon.cam1, 0xffffffff); gfar_write(®s->rmon.cam2, 0xffffffff); + /* Clear the CAR registers (w1c style) */ + gfar_write(®s->rmon.car1, 0xffffffff); + gfar_write(®s->rmon.car2, 0xffffffff); } /* Initialize ECNTRL */ -- 2.32.0