Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp381281pxj; Thu, 17 Jun 2021 05:04:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxR9zM5grdTVWci0ggjS6A+x3933O/ILGGFZgv8IiBJhmmbekasAOt1r+eLd2b99bacRV5 X-Received: by 2002:a05:6638:24d0:: with SMTP id y16mr4319145jat.41.1623931491981; Thu, 17 Jun 2021 05:04:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623931491; cv=none; d=google.com; s=arc-20160816; b=wMZursx7usHJ3fm6+SiZv53a/bYkk0yVcqvTasixhqa/X1Iyicx7bzdIEe9lroufk7 O0f7yhA6bEBidklLR3/1dV8XP0LZVqwfCK8XuuZxz+9xfE9fWPJX97KJXkfv2J/Wn3pY cIl9/he8RVrDzvdY22DHMj3to7ZotaGZxUKw7r2FB9JNACnMA85rWQoPEoxpUL7uShMR /iMASAVhaGBp2KIu/ss9DS8xNOJqnGcEoDJb9Nlhh1BK0N/E14MsNNGvB+H/b8zKgjkC +EPmK9+PgiBpSy/M20XW6Ts89+uKxWA/qHNWBTzDq9xs1bYk+aTQamP5UHV/ElZs8/sL ifWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MHYTtnSweqrT1SI+FeVF8umXEVRu64FZNM+a7Z6H3dE=; b=cUbR50wG5IjE0ZWH8ueJO+RLznYSZgM/WVEnx1ZvuxuEdBqiyiNrI1zAnw57+NR5OH 7AvVRC2zA6MMtwKnm/YvGovjzrrSN1M+PKV9kSQD+IY22OQQJYclIht/Z+bZIw1W3lj3 vrFw/41C0sjO3YG34hiK6NqWBUBJUeO6EyfJhLns64GfMfOUPiBguuZyEpBbe4WqBaVC 78ui7c2prz86JwWe8X8zr5PcCaW6rkMszApFr5hPT60+Xwmo70q1nX5OS5dNDHlLQ2Qc V2DoTEu0pxtx2AWg+0edLv01H0ns420QD/qWhvJLqmY6ra3eFa9kR/o6uys1dFSLTuVP jfaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@geanix.com header.s=first header.b=lPIb+TbA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=geanix.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r14si2462526ile.136.2021.06.17.05.04.37; Thu, 17 Jun 2021 05:04:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@geanix.com header.s=first header.b=lPIb+TbA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=geanix.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231891AbhFQJva (ORCPT + 99 others); Thu, 17 Jun 2021 05:51:30 -0400 Received: from first.geanix.com ([116.203.34.67]:41912 "EHLO first.geanix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231847AbhFQJv1 (ORCPT ); Thu, 17 Jun 2021 05:51:27 -0400 Received: from localhost (unknown [185.17.218.86]) by first.geanix.com (Postfix) with ESMTPSA id 648C64C3292; Thu, 17 Jun 2021 09:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=geanix.com; s=first; t=1623923358; bh=aDM42wVtbFCJQul8ZRo2dGnWDMYAECSz7+N9SXJwEfM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lPIb+TbAyDUb9X+kTt6qJiqah6OFv1RQPCh2F5hIfntOwc47MbXRhhCAUoT5vVdyB tiW2uMcB8lK544FeQpw1P+gLlQhlYMDoOO7sVCWwdaBL2zUqAnbdhFxoyhQHTrwwEp pZLEiVDhYmPQMtOqbyI1XU1wDHEJ7f+RY0/KFic5OK4BvNjhfjKMXg4NfCKGPvXYLx UfYcca/AfLRc/pm9cHjgn2c2rK+Byo5/G4bEI9hiEdgXtXCkVqWQnA7XqS/4eWTICn dByDs3dH8bUWo6ocK8MrF2Imj92TIYy+6vOzxaOnNEqbZLVAUFqCnxc9ujjbCiOORQ yj5hG63N7j73A== From: Esben Haabendal To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Rasmus Villemoes , Claudiu Manoil , "David S. Miller" , Jakub Kicinski Subject: [PATCH 2/6] net: gianfar: Extend statistics counters to 64-bit Date: Thu, 17 Jun 2021 11:49:17 +0200 Message-Id: X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=4.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on 93bd6fdb21b5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No reason to wrap counter values at 2^32. Especially the bytes counters can wrap pretty fast on Gbit networks. Signed-off-by: Esben Haabendal --- drivers/net/ethernet/freescale/gianfar.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar.h b/drivers/net/ethernet/freescale/gianfar.h index 5ea47df93e5e..d8ae5353e881 100644 --- a/drivers/net/ethernet/freescale/gianfar.h +++ b/drivers/net/ethernet/freescale/gianfar.h @@ -913,8 +913,8 @@ enum { * Per TX queue stats */ struct tx_q_stats { - unsigned long tx_packets; - unsigned long tx_bytes; + u64 tx_packets; + u64 tx_bytes; }; /** @@ -963,9 +963,9 @@ struct gfar_priv_tx_q { * Per RX queue stats */ struct rx_q_stats { - unsigned long rx_packets; - unsigned long rx_bytes; - unsigned long rx_dropped; + u64 rx_packets; + u64 rx_bytes; + u64 rx_dropped; }; struct gfar_rx_buff { -- 2.32.0