Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1621508727-24486-1-git-send-email-dillon.minfei@gmail.com>
 <1621508727-24486-2-git-send-email-dillon.minfei@gmail.com> <0f3145ce-3a01-3a77-2b65-85450bf9d920@xs4all.nl>
In-Reply-To: <0f3145ce-3a01-3a77-2b65-85450bf9d920@xs4all.nl>
From:   Dillon Min <dillon.minfei@gmail.com>
Date:   Thu, 17 Jun 2021 18:14:47 +0800
Message-ID: <CAL9mu0KeZ9Fq5wN-jJwK5S94N0qPXmsENtZXUx-KfjWxNjjecw@mail.gmail.com>
Subject: Re: [PATCH 1/7] media: admin-guide: add stm32-dma2d description
To:     Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Alexandre TORGUE <Alexandre.torgue@foss.st.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        mchehab+huawei@kernel.org, ezequiel@collabora.com,
        gnurou@gmail.com, Pi-Hsun Shih <pihsun@chromium.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Patrice CHOTARD <patrice.chotard@foss.st.com>,
        hugues.fruchet@foss.st.com,
        linux-media <linux-media@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-stm32@st-md-mailman.stormreply.com,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Hans

Thanks for your review on my code.

On Thu, Jun 17, 2021 at 5:56 PM Hans Verkuil <hverkuil-cisco@xs4all.nl> wro=
te:
>
> On 20/05/2021 13:05, dillon.minfei@gmail.com wrote:
> > From: Dillon Min <dillon.minfei@gmail.com>
> >
> > add stm32-dma2d description for dma2d driver
> >
> > Signed-off-by: Dillon Min <dillon.minfei@gmail.com>
> > ---
> >  Documentation/admin-guide/media/platform-cardlist.rst | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/admin-guide/media/platform-cardlist.rst b/Do=
cumentation/admin-guide/media/platform-cardlist.rst
> > index 261e7772eb3e..ac73c4166d1e 100644
> > --- a/Documentation/admin-guide/media/platform-cardlist.rst
> > +++ b/Documentation/admin-guide/media/platform-cardlist.rst
> > @@ -60,6 +60,7 @@ s5p-mfc            Samsung S5P MFC Video Codec
> >  sh_veu             SuperH VEU mem2mem video processing
> >  sh_vou             SuperH VOU video output
> >  stm32-dcmi         STM32 Digital Camera Memory Interface (DCMI)
> > +stm32-dma2d        STM32 Chrom-Art Accelerator Unit
>
> I have to ask: it is really 'Chrom-Art' and not Chrome-Art or Choma-Art?

Yes, I just double checked it from [1], it's really 'Chrom-Art' :)
it's should not be an spelling mistake, i check the soc's datasheet,
reference Manuel, all used 'Chrom-Art'.

...
Graphics

Chrom-ART Accelerator=E2=84=A2 (DMA2D), graphical hardware accelerator
enabling enhanced graphical user interface with minimum CPU load
...


[1] https://www.st.com/en/microcontrollers-microprocessors/stm32f469ni.html

Thanks.

Best Regards
Dillon

>
> It's probably correct, but I have to check this :-)
>
> Regards,
>
>         Hans
>
> >  sun4i-csi          Allwinner A10 CMOS Sensor Interface Support
> >  sun6i-csi          Allwinner V3s Camera Sensor Interface
> >  sun8i-di           Allwinner Deinterlace
> >
>