Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   SeongJae Park <sj38.park@gmail.com>
To:     "Boehme, Markus" <markubo@amazon.de>
Cc:     "sj38.park@gmail.com" <sj38.park@gmail.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "Foerster, Leonard" <foersleo@amazon.de>,
        "guoju.fgj@alibaba-inc.com" <guoju.fgj@alibaba-inc.com>,
        "brendanhiggins@google.com" <brendanhiggins@google.com>,
        "riel@surriel.com" <riel@surriel.com>,
        "greg@kroah.com" <greg@kroah.com>,
        "linux-damon@amazon.com" <linux-damon@amazon.com>,
        "david@redhat.com" <david@redhat.com>,
        "rientjes@google.com" <rientjes@google.com>,
        "Heyne, Maximilian" <mheyne@amazon.de>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Gowans, James" <jgowans@amazon.com>,
        "Park, Seongjae" <sjpark@amazon.de>,
        "snu@zelle79.org" <snu@zelle79.org>,
        "Woodhouse, David" <dwmw@amazon.co.uk>,
        "Jonathan.Cameron@Huawei.com" <Jonathan.Cameron@Huawei.com>,
        "Sieber, Fernand" <sieberf@amazon.com>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "rppt@kernel.org" <rppt@kernel.org>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "vbabka@suse.cz" <vbabka@suse.cz>,
        "zgf574564920@gmail.com" <zgf574564920@gmail.com>,
        "mgorman@suse.de" <mgorman@suse.de>,
        "amit@kernel.org" <amit@kernel.org>,
        "fan.du@intel.com" <fan.du@intel.com>,
        "minchan@kernel.org" <minchan@kernel.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>,
        "acme@kernel.org" <acme@kernel.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "gthelen@google.com" <gthelen@google.com>,
        "shakeelb@google.com" <shakeelb@google.com>,
        "elver@google.com" <elver@google.com>,
        "vdavydov.dev@gmail.com" <vdavydov.dev@gmail.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v30 12/13] mm/damon: Add user space selftests
Date:   Thu, 17 Jun 2021 11:35:04 +0000
Message-Id: <20210617113504.5525-1-sjpark@amazon.de>
In-Reply-To: <1ad122038f283961b787b26bb838a063ff7c43cf.camel@amazon.de>
Precedence: bulk

From: SeongJae Park <sjpark@amazon.de>

Hello Markus,

On Thu, 17 Jun 2021 11:29:41 +0000 "Boehme, Markus" <markubo@amazon.de> wrote:

> On Thu, 2021-06-17 at 11:28 +0000, Boehme, Markus wrote:
> > On Wed, 2021-06-16 at 07:31 +0000, SeongJae Park wrote:
> > > From: SeongJae Park <sjpark@amazon.de>
> > > 
> > > This commit adds a simple user space tests for DAMON.  The tests
> > > are
> > > using kselftest framework.
> > > 
> > > Signed-off-by: SeongJae Park <sjpark@amazon.de>
> > > ---
> > >  tools/testing/selftests/damon/Makefile        |  7 ++
> > >  .../selftests/damon/_chk_dependency.sh        | 28 +++++++
> > >  .../testing/selftests/damon/debugfs_attrs.sh  | 75
> > > +++++++++++++++++++
> > >  3 files changed, 110 insertions(+)
> > >  create mode 100644 tools/testing/selftests/damon/Makefile
> > >  create mode 100644
> > > tools/testing/selftests/damon/_chk_dependency.sh
> > >  create mode 100755 tools/testing/selftests/damon/debugfs_attrs.sh
> > > 
> > > [...]
> > > diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh
> > > b/tools/testing/selftests/damon/debugfs_attrs.sh
> > > new file mode 100755
> > > index 000000000000..60342d6c86d8
> > > --- /dev/null
> > > +++ b/tools/testing/selftests/damon/debugfs_attrs.sh
[...]
> > > +
> > > +test_content() {
> > > +	file=$1
> > > +	orig_content=$2
> > > +	expected=$3
> > > +	expect_reason=$4
> > > +
> > > +	content=$(cat "$file")
> > > +	if [ "$content" != "$content" ]
> > 
> > That'll always evaluate false and should compare against "expected"
> > instead.

Good catch, I will fix so in the next spin.

> > 
> 
> Feel free to add Reviewed-by: Markus Boehme <markubo@amazon.de> when
> this is fixed.

Thank you!

> 
> > > +	then
> > > +		echo "reading $file expected $expected but $content"
> > > +		echo "expected because: $expect_reason"
> > > +		echo "$orig_content" > "$file"
> > > +		exit 1
> > > +	fi
> > > +}


Thanks,
SeongJae Park

[...]