Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp460573pxj; Thu, 17 Jun 2021 06:45:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJym58DWmb+4zuO7nWqXgu2upZn8CWr9PgwOxjxj/fVilveJMM9LfQULBM6VwjE21efzYJvF X-Received: by 2002:a17:906:4112:: with SMTP id j18mr5102135ejk.405.1623937532204; Thu, 17 Jun 2021 06:45:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623937532; cv=none; d=google.com; s=arc-20160816; b=mN1f1zPvVTC0vIZDeHjd2q5/3IwALZBMJGCOajiT49towzqogVcNdyDn8bxm6Zzcdi h4ylkWfInv7C+Df4pyU669BOfJKWeMEE1yDHnI8Ne3A7xI47hbDmkFN7YHyGLnvkp2X2 GOpBh7h28f+LcVps1RHxNS4WsPkNAN0hQVsDekyxBxpZ4DGVod9Bj0/HkJDyiVOIhdh9 IZJGHw/X7HbfwQKHtHpHbLGtjNxMN8yTpUQl691BMF+hkC7XLWMOzm2ny3bO4DkgqLQj 5N7I860PfL0sVCDIeGd0+M+SHNb3fN2iLWOjxnhI+SA02Szhc25k6NRe1WqTDyxsnbwK UWrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=a6VLhh5EpNq2s0Zgnl4Z4+/6A+zL4UAulfMKWii6zRo=; b=wzIASH/ei6XnSgyD4K5Bpwaep+YVk7C/PosO66Y8kI3vp4gx/EZJmOyJvwOl71gI3S TM6O5WLv/obq5xmgg0bpBtTJW4FKKkOHU7QCdN/KSqrKe60ic9urdxqIKjrGIFlRLQqN wz+50GsMoNT7lYBNuwZXrYm8y0XsZiKBbNvJQ/vre8S+RYuTIT1rXqO2H8R9XInjvvzy ysaObASJ7mZkU7ohT5/eYuXF53EemQHFJxzrMo3Wu3vlew4z0xpWOulHo1Ka/r04S22F ASRs77O+3MV7j/PPb+1vLelXkbmabztAln3xjAI9cH79hK25tNge2pWcS0uBAUo0JGSg vZXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m22si5099907ejn.250.2021.06.17.06.45.07; Thu, 17 Jun 2021 06:45:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232622AbhFQMDk (ORCPT + 99 others); Thu, 17 Jun 2021 08:03:40 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:49909 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231490AbhFQMDi (ORCPT ); Thu, 17 Jun 2021 08:03:38 -0400 Received: (Authenticated sender: alex@ghiti.fr) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id EA9E86000F; Thu, 17 Jun 2021 12:01:25 +0000 (UTC) From: Alexandre Ghiti To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Jisheng Zhang , Christoph Hellwig , Zong Li , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Alexandre Ghiti Subject: [PATCH v5 0/2] riscv: Map the kernel with correct permissions the first time Date: Thu, 17 Jun 2021 14:01:22 +0200 Message-Id: <20210617120124.1752541-1-alex@ghiti.fr> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The kernel permissions are fixed after the kernel page table is created: avoid that by mapping the kernel 'correctly' the first time. Patch 1 introduces a new helper to set kernel mapping permissions while avoiding all the casts when using set_memory_* API. Patch 2 is the bulk of this work and deals with mapping the kernel with the right permissions. Changes in v5: * Remove non-relevant commits to this patchset that raised issues * Make load_sz non-static as it is used in kernel address conversions macros * Rebased on top for-next Changes in v4: * Add patch 1 as noted by Jisheng * Changes patch 2 title as suggested by Anup * Add Reviewed-by from Anup Changes in v3: * Add a patch that factorizes kernel address conversions * Add a helper called set_kernel_memory in its own patch, as suggested by Christoph * Prefer IS_ENABLED over #ifdef, as suggested by Christoph * Split overly long lines, as suggested by Christoph * Simplify kernel mapping by mapping ALL text as readonly and taking advantage of already present code that enables write for init text before free_initmem_default. Changes in v2: * Rebased on top of for-next (and "riscv: mm: fix build errors caused by mk_pmd()") * Get rid of protect_kernel_linear_mapping_text_rodata as suggested by Jisheng * Improve code in general compared to previous RFC Alexandre Ghiti (2): riscv: Introduce set_kernel_memory helper riscv: Map the kernel with correct permissions the first time arch/riscv/include/asm/page.h | 13 +++- arch/riscv/include/asm/sections.h | 17 +++++ arch/riscv/include/asm/set_memory.h | 13 ++-- arch/riscv/kernel/setup.c | 11 +-- arch/riscv/mm/init.c | 108 ++++++++++++---------------- arch/riscv/mm/pageattr.c | 10 +++ 6 files changed, 91 insertions(+), 81 deletions(-) -- 2.30.2