Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp506648pxj; Thu, 17 Jun 2021 07:39:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1rahkTU4xXcM6YZbRnCfWPXr9NQYkl8pya2MMig+x0OszTIzSyOjVIeml8rbi5NFFgvyM X-Received: by 2002:a05:6402:1c83:: with SMTP id cy3mr6803667edb.108.1623940771880; Thu, 17 Jun 2021 07:39:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623940771; cv=none; d=google.com; s=arc-20160816; b=kHUDk0DhAbGItdZ16m3hR8RGOyrFEtwEJe8y0wvogPmdc4qcb3Siw0r2IiPlI4nemK 1dmG7yq4AZGeRqjFiqAlfSaFV0nGHqyyThnOBAQODVfabxQ4zWAmn3RsykQV8tRMXWMo 70bmQQO3gnH3ZxlPAfG7UipzhQlxVR4jIX7rSj5Gs5OroO3zHaSCH9fKvOanTWS9CcgY AYkRbH/XeiIUEE0nl3F1pgiarOKcPSZkn285DeJ4kdRSfMpQj9s97mb2wzXX6ViaF+xB IB3sX4TvBchtgCJh1DAXStAaKGMi7JcJBcTvPofFK3aLo4BddYSO6+CGdLgGS0MYrqPi eyOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=IVf3VdYFDG8Vd4xYtq67HwQqNa2iRHaHJF+HzVaN17Y=; b=Fq0MLY66utsRYHN9GWyeXokHlc4g0yS+OBji1brz51WiC18WMt4d4amJ3JA/4GnH2L bSNoCoZuejhPlq+1AAV5JcdqNC7AKqwNJzQwjA/BH+CGs5PDvrhV+kyyqCfegaVWtbs5 dOqGeVxlXNRM3Z8jxlb3zR1dRuGjad2Y5c4XxtaGfbzOUbjbwvbO/17yKcYDVyhXzbqQ 3ur/JHbpX5cglWxlxTmQGCedg20ty2vA92DjaU6G+Uw5UTOZ5hDUPLA727js1iF5OsXZ jZ+wsYAnWrM5GJuU+njSEjKkjLgZktmh1Ssxp/we1//MCze5j7D8WlR0ekayb0MX/CnX WB6A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gv25si5436710ejc.161.2021.06.17.07.39.08; Thu, 17 Jun 2021 07:39:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232974AbhFQOIr (ORCPT + 99 others); Thu, 17 Jun 2021 10:08:47 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:8262 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232941AbhFQOIo (ORCPT ); Thu, 17 Jun 2021 10:08:44 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4G5NyK6fHQz1BNRn; Thu, 17 Jun 2021 22:01:29 +0800 (CST) Received: from dggemi759-chm.china.huawei.com (10.1.198.145) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Thu, 17 Jun 2021 22:06:32 +0800 Received: from localhost.localdomain (10.67.165.24) by dggemi759-chm.china.huawei.com (10.1.198.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 17 Jun 2021 22:06:32 +0800 From: Guangbin Huang To: , , , , CC: , , , Subject: [PATCH V2 net-next 4/6] net: hdlc_ppp: move out assignment in if condition Date: Thu, 17 Jun 2021 22:03:17 +0800 Message-ID: <1623938599-25981-5-git-send-email-huangguangbin2@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1623938599-25981-1-git-send-email-huangguangbin2@huawei.com> References: <1623938599-25981-1-git-send-email-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggemi759-chm.china.huawei.com (10.1.198.145) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peng Li Should not use assignment in if condition. Signed-off-by: Peng Li Signed-off-by: Guangbin Huang --- drivers/net/wan/hdlc_ppp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c index 861491206f12..fb5102c1afc6 100644 --- a/drivers/net/wan/hdlc_ppp.c +++ b/drivers/net/wan/hdlc_ppp.c @@ -375,7 +375,8 @@ static void ppp_cp_parse_cr(struct net_device *dev, u16 pid, u8 id, u8 *out; unsigned int len = req_len, nak_len = 0, rej_len = 0; - if (!(out = kmalloc(len, GFP_ATOMIC))) { + out = kmalloc(len, GFP_ATOMIC); + if (!out) { dev->stats.rx_dropped++; return; /* out of memory, ignore CR packet */ } -- 2.8.1