Date: Wed, 08 Nov 2006 23:00:59 -0800 (PST)
Message-Id: <20061108.230059.57444310.davem@davemloft.net>
To: kenneth.w.chen@intel.com
Cc: akpm@osdl.org, jgarzik@pobox.com, linux-kernel@vger.kernel.org,
       netdev@vger.kernel.org
Subject: Re: [patch] fix up generic csum_ipv6_magic function prototype
From: David Miller <davem@davemloft.net>
In-Reply-To: <000301c703a3$0eedb340$ff0da8c0@amr.corp.intel.com>
References: <000301c703a3$0eedb340$ff0da8c0@amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 880
Lines: 21

From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Date: Wed, 8 Nov 2006 18:02:06 -0800

> The generic version of csum_ipv6_magic has the len argument declared as
> __u16, while most arch dependent version declare it as __u32.  After
> looking at the call site of this function, I come up to a conclusion
> that __u32 is a better match with the actual usage.
> 
> Hence, patch to change argument type for greater consistency.
> 
> Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>

Architecture implementations such as the ones for m32r and parisc have
the same problem, so "for consistency" please fix them up as well.

Thanks a lot.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/