Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp604298pxj; Thu, 17 Jun 2021 09:34:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfn1ZouC8Cf6h2I7MmqJvvA15ipxpb6h6O9ov487j24mjgZ3HmIy+kOwfDITgv82QxaAM6 X-Received: by 2002:aa7:c54c:: with SMTP id s12mr7830151edr.374.1623947679083; Thu, 17 Jun 2021 09:34:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623947679; cv=none; d=google.com; s=arc-20160816; b=aNFPgwyZ5zxhIxsboWXXcr3veVrfOZijXWSNXAZ0zqWBM6J6KcDxZbJhnpTkIKzZFl Ffx60U5a5Pl0pDkPjXgt8Ynf3mwWhqvi0TPyKzt7Q549of8nYDOZaPPtvr5L5uhIusRv 12P4m77b04iryMC+7bcjLWN5IFiScbZAzeaU59DtfQLQLleLnNVVqJSzMwbCsB3ANJ8M zBj5iGP1a4OEaDeNQUgY7WKnFH0jql14X7bSiNuFsDbQffGCesiUVNEX+7HX4aAcS4w2 0scJ6ny5czoSDJVyRHpDCr+0MtFUj63TL/sW4bzmn8LT7i1u5NKqS0yYCg/nk8ldn8XN jVtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wKKVhPiz/c99/Aot49JXhSgZm5nwDFI+TVyS7BHrs1Q=; b=d7o/eHLid4Rri83sNAPabD1rl4pdI2Gc+IEmCDwxKa0XCl4XWm25jf9A0AqPJBguOM mu1JuJ93XWWbLYfQsuM5H8Whl0Z7bUQUDJa7Igpij9ubfKCswZnM7fqjMBcwuF7pghhN yGrh2DGaMUKh/L6CtpGBKUcLSEtrCkhsoz1IzplcXx0ADX3mfin7lQriHW7Zfdx1A60y 2sgkx7SN+ybfo72dfdYw8370JScNupxTLFoQMPGSemPxjm01U1HAk2Es9fHjepiikPv0 duRY4+4m/TxhJIfgbyJq80FvseYimR2ouKs/kM+0f+smbMzXj61RNzEQRbIZ3BucxwDb LrBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ugZ6HqjG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ia8si4032848ejc.187.2021.06.17.09.34.15; Thu, 17 Jun 2021 09:34:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ugZ6HqjG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232682AbhFQQbq (ORCPT + 99 others); Thu, 17 Jun 2021 12:31:46 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:43036 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230269AbhFQQbp (ORCPT ); Thu, 17 Jun 2021 12:31:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=wKKVhPiz/c99/Aot49JXhSgZm5nwDFI+TVyS7BHrs1Q=; b=ugZ6HqjGG4twSb8tgaPw0U7Z/d +Ylbpn6jS3+2eQkfq/kXIZeM+3/rA+LHR7IQZwl8PHilTtVU+CcJx2WDLk4jv0BiJWwHk5xumkGno A0LTLtc+c/ebg3V3LczcPo3tewzTrUr0TTq2qsDu+DW360k5HeX1R/ydzjME0OpmVZgs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ltutQ-009wAz-Mo; Thu, 17 Jun 2021 18:29:24 +0200 Date: Thu, 17 Jun 2021 18:29:24 +0200 From: Andrew Lunn To: Peng Li Cc: davem@davemloft.net, kuba@kernel.org, xie.he.0141@gmail.com, ms@dev.tdt.de, willemb@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, huangguangbin2@huawei.com Subject: Re: [PATCH net-next 5/6] net: hostess_sv11: fix the comments style issue Message-ID: References: <1623941615-26966-1-git-send-email-lipeng321@huawei.com> <1623941615-26966-6-git-send-email-lipeng321@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623941615-26966-6-git-send-email-lipeng321@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -152,12 +146,12 @@ static int hostess_close(struct net_device *d) > static int hostess_ioctl(struct net_device *d, struct ifreq *ifr, int cmd) > { > /* struct z8530_dev *sv11=dev_to_sv(d); > - z8530_ioctl(d,&sv11->chanA,ifr,cmd) */ > + * z8530_ioctl(d,&sv11->chanA,ifr,cmd) > + */ > return hdlc_ioctl(d, ifr, cmd); > } That looks more like dead code than anything else. I would suggest you do a git blame to see if there is anything interesting about this, and if not, remove it. Andrew