Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Jun 2021 20:03:07 +0300
From:   Ido Schimmel <idosch@idosch.org>
To:     Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Cc:     jiri@nvidia.com, davem@davemloft.net, kuba@kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Vadym Kochan <vadym.kochan@plvision.eu>
Subject: Re: [PATCH net-next v2] drivers: net: netdevsim: fix devlink_trap
 selftests failing
Message-ID: <YMuAS++AH6DknYPA@shredder>
References: <20210617113632.21665-1-oleksandr.mazur@plvision.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210617113632.21665-1-oleksandr.mazur@plvision.eu>
Precedence: bulk

On Thu, Jun 17, 2021 at 02:36:32PM +0300, Oleksandr Mazur wrote:
> devlink_trap tests for the netdevsim fail due to misspelled
> debugfs file name. Change this name, as well as name of callback
> function, to match the naming as in the devlink itself - 'trap_drop_counter'.
> 
> Test-results:
> selftests: drivers/net/netdevsim: devlink_trap.sh
> TEST: Initialization                                                [ OK ]
> TEST: Trap action                                                   [ OK ]
> TEST: Trap metadata                                                 [ OK ]
> TEST: Non-existing trap                                             [ OK ]
> TEST: Non-existing trap action                                      [ OK ]
> TEST: Trap statistics                                               [ OK ]
> TEST: Trap group action                                             [ OK ]
> TEST: Non-existing trap group                                       [ OK ]
> TEST: Trap group statistics                                         [ OK ]
> TEST: Trap policer                                                  [ OK ]
> TEST: Trap policer binding                                          [ OK ]
> TEST: Port delete                                                   [ OK ]
> TEST: Device delete                                                 [ OK ]
> 
> Fixes: a7b3527a43fe ("drivers: net: netdevsim: add devlink trap_drop_counter_get implementation")
> Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>