Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp666821pxj; Thu, 17 Jun 2021 10:59:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdncyUJLmQUo27GbuuecdYl0eU8jvgi1xrzJenfQJwF99cPXooKY+/O6vfe820tc1CKBZi X-Received: by 2002:a05:6402:28a:: with SMTP id l10mr8292244edv.365.1623952783527; Thu, 17 Jun 2021 10:59:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623952783; cv=none; d=google.com; s=arc-20160816; b=VMkpQe0WkSlvgCw+Q5U5tSSHSX/0vIQ21PFEzn405aykExmwokyYGMzuUus1NLb94k XijEU3hIAcmNKXyI1C6p60iRmg0gEsqEnajhK16w4W5xaDcX+CsG6gmheaTs1hR9ahHm +Wm3/+yIUhsoaRJMWkd7OBFudxwYJ8Z91RSpK/pYNo6AefKx9MI75Y3U6ZDsRhRn1O+7 AmIaz8MwiZYxwM9kUgvvOy515FhCMuvyLCBnx273E4DmhQqPhYR2gp+3mtoVbZ+XhcIa qdjY5QG4AvJThOFxtMUKMC5Xm5e5VyX8728ldgyegrS4n22AsriASk9oUp7zE5L7eyAW FQ/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Q23K6shgqdJyPgud7XabXu/fDiLH6iOcPzrfRuQUOR8=; b=JgiXtVObdXX0lWnGlsaxY9I1q8skqvOo9XajevNelgcBqoXFUUgQLsa8jjZacHbbfU h8rUiM3iV7ednJSZbPJWeBQRYMX4vKjVSiWyN0wWgYkrNpGT86ALCZrdjUFN9jcCM8v3 yngjK/lxPX2TKtpCN6Yf9GMw1lcrW2pKA5eOjUVQWljfz2l7lP/XbyLFTEESZankA09X 0H1MI7gKkR3HlOaDCmoXuvf7phetYeow1Wn0DUUfCFy5CrDc5/FGrlmpofvKLVFIcUbx GrRZ4XetwedMbybHGmCQs60RuxrSvXZPgbMF6+j6bPX6+1U2jbsMCEuF+J96SQl01Mij fGLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s3si5991532edd.265.2021.06.17.10.59.08; Thu, 17 Jun 2021 10:59:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232186AbhFQNUB (ORCPT + 99 others); Thu, 17 Jun 2021 09:20:01 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:62359 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231224AbhFQNUA (ORCPT ); Thu, 17 Jun 2021 09:20:00 -0400 Received: (Authenticated sender: alex@ghiti.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 5BDAD240004; Thu, 17 Jun 2021 13:17:47 +0000 (UTC) From: Alexandre Ghiti To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Jisheng Zhang , Christoph Hellwig , Zong Li , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Alexandre Ghiti Subject: [PATCH v6 0/2] Map the kernel with correct permissions the first time Date: Thu, 17 Jun 2021 15:17:32 +0200 Message-Id: <20210617131734.1923932-1-alex@ghiti.fr> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The kernel permissions are fixed after the kernel page table is created: avoid that by mapping the kernel 'correctly' the first time. Patch 1 introduces a new helper to set kernel mapping permissions while avoiding all the casts when using set_memory_* API. Patch 2 is the bulk of this work and deals with mapping the kernel with the right permissions. Changes in v6: * load_sz was placed in init section but is now used in kernel address conversions macros, so remove this attribute. Changes in v5: * Remove non-relevant commits to this patchset that raised issues * Make load_sz non-static as it is used in kernel address conversions macros * Rebased on top for-next Changes in v4: * Add patch 1 as noted by Jisheng * Changes patch 2 title as suggested by Anup * Add Reviewed-by from Anup Changes in v3: * Add a patch that factorizes kernel address conversions * Add a helper called set_kernel_memory in its own patch, as suggested by Christoph * Prefer IS_ENABLED over #ifdef, as suggested by Christoph * Split overly long lines, as suggested by Christoph * Simplify kernel mapping by mapping ALL text as readonly and taking advantage of already present code that enables write for init text before free_initmem_default. Changes in v2: * Rebased on top of for-next (and "riscv: mm: fix build errors caused by mk_pmd()") * Get rid of protect_kernel_linear_mapping_text_rodata as suggested by Jisheng * Improve code in general compared to previous RFC Alexandre Ghiti (2): riscv: Introduce set_kernel_memory helper riscv: Map the kernel with correct permissions the first time arch/riscv/include/asm/page.h | 13 +++- arch/riscv/include/asm/sections.h | 17 +++++ arch/riscv/include/asm/set_memory.h | 13 ++-- arch/riscv/kernel/setup.c | 11 +-- arch/riscv/mm/init.c | 108 ++++++++++++---------------- arch/riscv/mm/pageattr.c | 10 +++ 6 files changed, 91 insertions(+), 81 deletions(-) -- 2.30.2