Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754786AbWKIKdC (ORCPT ); Thu, 9 Nov 2006 05:33:02 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754796AbWKIKdB (ORCPT ); Thu, 9 Nov 2006 05:33:01 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:25028 "EHLO mx2.mail.elte.hu") by vger.kernel.org with ESMTP id S1754786AbWKIKdA (ORCPT ); Thu, 9 Nov 2006 05:33:00 -0500 Date: Thu, 9 Nov 2006 11:31:35 +0100 From: Ingo Molnar To: Adrian Bunk Cc: Andrew Morton , Ingo Molnar , Stefan Richter , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.19-rc3] i386/io_apic: fix compiler warning in create_irq Message-ID: <20061109103135.GA3748@elte.hu> References: <20061030090231.GA27146@elte.hu> <20061030170445.1dedce1e.akpm@osdl.org> <1162287457.15286.186.camel@earth> <20061031014914.9af0dde9.akpm@osdl.org> <20061031111502.GA21450@elte.hu> <20061031190955.GU27968@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061031190955.GU27968@stusta.de> User-Agent: Mutt/1.4.2.2i X-ELTE-SpamScore: -2.8 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.8 required=5.9 tests=ALL_TRUSTED,AWL,BAYES_50 autolearn=no SpamAssassin version=3.0.3 -3.3 ALL_TRUSTED Did not pass through any untrusted hosts 0.5 BAYES_50 BODY: Bayesian spam probability is 40 to 60% [score: 0.5000] -0.0 AWL AWL: From: address is in the auto white-list X-ELTE-VirusStatus: clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 21 * Adrian Bunk wrote: > On Tue, Oct 31, 2006 at 12:15:02PM +0100, Ingo Molnar wrote: > >... > > we definitely do not want to hide these places. They both make the > > code less readable (why initialize it to some value if that value is > > never used) and they hide the problem from the GCC folks too. > > What about cases where it's technically impossible for gcc to ever see > that a variable actually gets initialized? we should mark them as such or even initialize them outright. But these are the exception. Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/