Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>
CC:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH 2/2] clk: renesas: Avoid mixing error pointers and NULL
Thread-Topic: [PATCH 2/2] clk: renesas: Avoid mixing error pointers and NULL
Thread-Index: AQHXY4M3wrjBeuM+7kuOudE2VajpBKsYQlag
Date:   Thu, 17 Jun 2021 14:40:24 +0000
Message-ID: <OSZPR01MB70199F49C5F64B7245B0BE57AA0E9@OSZPR01MB7019.jpnprd01.prod.outlook.com>
References: <YMtYs7LVveYH4eRe@mwanda> <YMtY7nOtqEvTokh7@mwanda>
In-Reply-To: <YMtY7nOtqEvTokh7@mwanda>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4lNd0IRhzCbsI5M4g0obwyBm31QqjYU1/F6H57n7wse0PkWtd1ccgtab3R3L?=
 =?us-ascii?Q?IDmFVFcGmxfLBGmfblDXz6dObBfKMRC3Ezm/sy0sGZx3Q0iFzbINIcWC5/Br?=
 =?us-ascii?Q?skMToQMUe3QFxxh0F5LecvH0IHobdODXxQBA7IXNrrJwjCUXS5uBy0iAExbd?=
 =?us-ascii?Q?/DkBvCaSd4M5vefctJO/YmHlBUSDYyJEPzvQHcZDQWJZjnKI/SZKE2PSgtyh?=
 =?us-ascii?Q?fSrqLalyNIUgG411LgUkmPNX5Ij+FNHi+AiNY/OKHDUrfXYxeO+AY/pR3lI4?=
 =?us-ascii?Q?knXc15btKQU1IFQ9bVj3ySKiSAdixpTBal4vjcZW++ahsVaTaUdtTjnF+2Hm?=
 =?us-ascii?Q?FFTWi1dbghU6BBS1SqdxBQKwoj7VhUpZTNF3Q2tra4bEVnDIKDGi8xQOQlP5?=
 =?us-ascii?Q?MFkj3VdTPKnNam5WxqsoAxkMOXidwNuyieGiAam+Mw4Ycec0tHjqyiZ1uULe?=
 =?us-ascii?Q?7UVHtYcr71NJT9To8k7hzDSVaJkn56krYOUB/FlxDyKONScmO6AMuM4B0+69?=
 =?us-ascii?Q?kyn0s6tmp9f7ZpwXsBvdQ0gYwwvAA6iyT8/ICOAkFpOXccwyhm2BKy5lYT/Q?=
 =?us-ascii?Q?85zk1G+2d2ZjJUNrNe9LAGmefoIt5iGZRwWtPYu730ML8gObDDMFyO9lP7eL?=
 =?us-ascii?Q?auwiLk/YoUiq7bbvXeCEuyxzaQ7t1yzOoxD74oTo/Ia+gRYpc0aJPkvu9N7W?=
 =?us-ascii?Q?TWysxC0PvRiMuLNmkgyXKNUqMOo15WcLJCB2NzSKC0AgI6hwAacWwdkg5jDH?=
 =?us-ascii?Q?iQu9VNbmkihDRACx6/qqKPEM08+RreEsUCKsGSRRNYlJacNUmOUyePXbPCas?=
 =?us-ascii?Q?71YnD69qiXZ5h46DCREuMmDb6gOuCSN9miIAJIE1ZU3Cd1B+F+2W9cyZaC9D?=
 =?us-ascii?Q?XxtGNgjFz6vsuEzDYgllV64BIRfMZ4H/QJO7CfYuxAwGPvfzD16MMaKgMTu7?=
 =?us-ascii?Q?TtcADf+3p7b+43rMrWRIIRljlw3oKWP5Cdb2v7MCsJ/mBiG8wR7b0TVnrPQI?=
 =?us-ascii?Q?wTTNG2i5VQYgFG77HSBWHGrSBORWFPKRNxqYc55f11UdOecRW7Tf6bCd0hDC?=
 =?us-ascii?Q?+iGb4c68rZB9LUE4i5niHL/dt01SWPRk8QfQCfseeuPU8YdDmpJdwpEYYGlx?=
 =?us-ascii?Q?ZckRB92C1ekbuR4sVIOXEHFpLHU9+aOAkR08m/Gfosmsj7JZviJsfdJdBFxh?=
 =?us-ascii?Q?6o5BfisYnyfKdVYRmFki2IJVdVDeqvtv78WRYBcwpBBa1/l92qPsQqmCP8Ny?=
 =?us-ascii?Q?3naEMNuAuU9RYTQQW6stMcdHMqBIR7hoWBDh1l+3YSOf97/vVuK6Ewp7BTDp?=
 =?us-ascii?Q?3h1G3ojCEAx9kwudCMoyhpf3?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSZPR01MB7019.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 611e27fa-28e8-40d3-f59c-08d9319dd791
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2021 14:40:24.4406
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: aeFFgjCwiamtTiR2JgNWn4ggHC4HnaNDOEHloVhhObLKxY9eAfkaTvgg1/1Q3+fRKbJvalmJwyAElt2hKbV24f8YpYRzNMdPCajXiPkgInRBo91gypy3LijEAgKh/dvP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB1571
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dan,

Thank you for the patch.

> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Sent: 17 June 2021 15:15
> To: Geert Uytterhoeven <geert+renesas@glider.be>; Prabhakar Mahadev Lad <=
prabhakar.mahadev-
> lad.rj@bp.renesas.com>
> Cc: Michael Turquette <mturquette@baylibre.com>; Stephen Boyd <sboyd@kern=
el.org>; linux-renesas-
> soc@vger.kernel.org; linux-clk@vger.kernel.org; linux-kernel@vger.kernel.=
org; kernel-
> janitors@vger.kernel.org
> Subject: [PATCH 2/2] clk: renesas: Avoid mixing error pointers and NULL
>=20
> These functions accidentally return both error pointers and NULL when the=
re is an error.  It doesn't
> cause a problem but it is confusing and seems unintentional.
>=20
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/clk/renesas/renesas-rzg2l-cpg.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>=20

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/clk/renesas/renesas-rzg2l-cpg.c b/drivers/clk/renesa=
s/renesas-rzg2l-cpg.c
> index 7ba36f19896f..83b58e1cb78f 100644
> --- a/drivers/clk/renesas/renesas-rzg2l-cpg.c
> +++ b/drivers/clk/renesas/renesas-rzg2l-cpg.c
> @@ -124,7 +124,7 @@ rzg2l_cpg_div_clk_register(const struct cpg_core_clk =
*core,
>  						 core->flag, &priv->rmw_lock);
>=20
>  	if (IS_ERR(clk_hw))
> -		return NULL;
> +		return ERR_CAST(clk_hw);
>=20
>  	return clk_hw->clk;
>  }
> @@ -174,17 +174,14 @@ rzg2l_cpg_pll_clk_register(const struct cpg_core_cl=
k *core,
>  	struct clk_init_data init;
>  	const char *parent_name;
>  	struct pll_clk *pll_clk;
> -	struct clk *clk;
>=20
>  	parent =3D clks[core->parent & 0xffff];
>  	if (IS_ERR(parent))
>  		return ERR_CAST(parent);
>=20
>  	pll_clk =3D devm_kzalloc(dev, sizeof(*pll_clk), GFP_KERNEL);
> -	if (!pll_clk) {
> -		clk =3D ERR_PTR(-ENOMEM);
> -		return NULL;
> -	}
> +	if (!pll_clk)
> +		return ERR_PTR(-ENOMEM);
>=20
>  	parent_name =3D __clk_get_name(parent);
>  	init.name =3D core->name;
> --
> 2.30.2