Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Jun 2021 17:12:16 +0200
From:   Jan Kara <jack@suse.cz>
To:     Colin King <colin.king@canonical.com>
Cc:     Pan Bian <bianpan2016@163.com>, Jan Kara <jack@suse.cz>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] isofs: remove redundant continue statement
Message-ID: <20210617151216.GH32587@quack2.suse.cz>
References: <20210617120837.11994-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210617120837.11994-1-colin.king@canonical.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Thu 17-06-21 13:08:37, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The continue statement in the while-loop has no effect,
> remove it.
> 
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks! I've added the patch to my tree.

								Honza

> ---
>  fs/isofs/dir.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/isofs/dir.c b/fs/isofs/dir.c
> index b9e6a7ec78be..eb2f8273e6f1 100644
> --- a/fs/isofs/dir.c
> +++ b/fs/isofs/dir.c
> @@ -235,8 +235,6 @@ static int do_isofs_readdir(struct inode *inode, struct file *file,
>  				break;
>  		}
>  		ctx->pos += de_len;
> -
> -		continue;
>  	}
>  	if (bh)
>  		brelse(bh);
> -- 
> 2.31.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR