Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] drm/amd/display: remove unused variable 'dc'
To:     Pu Lehui <pulehui@huawei.com>, sunpeng.li@amd.com,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch,
        Anson.Jacob@amd.com, Nicholas.Kazlauskas@amd.com, roman.li@amd.com
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, zhangjinhao2@huawei.com
References: <20210617011632.187690-1-pulehui@huawei.com>
From:   Harry Wentland <harry.wentland@amd.com>
Message-ID: <7758a4ef-0b8e-8873-fac0-7db7a2f6402b@amd.com>
Date:   Thu, 17 Jun 2021 15:04:21 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
In-Reply-To: <20210617011632.187690-1-pulehui@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.50.3] (198.200.67.154) by YQBPR0101CA0106.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.16 via Frontend Transport; Thu, 17 Jun 2021 19:04:24 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 30254615-3f64-4439-588c-08d931c2bbe2
X-MS-TrafficTypeDiagnostic: CO6PR12MB5410:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO6PR12MB54100914F4A1BDA3E92294328C0E9@CO6PR12MB5410.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:46;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +Mkd7MeD2IIPiBHfpRA8WaSlyh78SJTbLRGVfsJA5Qlb/nZVGy4bU6DpQ+biKCdGuU8Q6Oks/uV54ICQ4KJxZc0GadIDbEBvZfm08P5WWCkctzDy1KM+7Usw2qIkxACoCV1fmSWZVBBVjoRpEYS3gqlP1XZ21f/OpHfCD9gLoGN8UCobQNs+IXDJwtX55RpLviHKapgUhUdj09xgpOrXlNGSgOG2laQymKKhNY5kJqlxIL6IVUH5fbHA2TbMdE427pKsFG6RBi49rzLXBXzB0vKF/2WrXKjYeOWaGRJHLWadpbLhFX2E5VJBan+qyeZbPLBjzwXr9SuBd4LKc1VkuImbOxwVrrEuxKYy1+1UyEHnbY/VjIC1FtcysxAh1ESmfjNFHhJotu8iz+xgUbVU+UkDyGfsltcosdMP0sWY0UKKvG0C78X7BHGfvJXxFiW4OXiflO/iLhmgCNMoWHbxepXbMPUhSSVyWCxrX/8VD7VeJyqSELNlD7UdLeUrh9DRPJyZ0WjSA/HUoImElhus1O8Vg+ACFeeE93n816+AfqtGedMb6CHMN9CxxN4WMvjvTJ3dHk/Ldwx+soK4x8jE6Xa4pKM6tbeijmInfEVRJ4lrGftEhx3H1hdxCeyvr+09Q9+Zx/JYA2XTK1q8bl6BjCgpjW7uzZWCf4jtsGvhZiBsvsiKmUNtSE3M1sTYiHUdpRNxc93ObsZzNV+2woPdIg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO6PR12MB5427.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(39860400002)(376002)(136003)(366004)(956004)(2906002)(6636002)(478600001)(316002)(86362001)(83380400001)(44832011)(36756003)(186003)(5660300002)(2616005)(6666004)(8936002)(8676002)(4326008)(26005)(16576012)(16526019)(31686004)(31696002)(66946007)(66476007)(66556008)(38100700002)(6486002)(53546011)(921005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ykt1c3NaaXFncEswQ3hNWEtSTkxYQnNCZ1Y1bWM5YTFjY0NicFZhUHlNQUQz?=
 =?utf-8?B?U2gxMzZ5YkNGT012aTJ3NDc5YVB0RjRXTVJiVkZEVjI2bU1BbVhndG9ydGVE?=
 =?utf-8?B?UUZBZElYTGRtUkk2YzlwVmZkTUMxTDZVNXdXYWFhakVaRWJPOVRwak5aZTFl?=
 =?utf-8?B?SlpDd25oMnlKcWJod1BTLzZHeG56MmNJOTdhU0lZTmhhbXVRV3pxVDhhOGpp?=
 =?utf-8?B?YitjMHhFVFJPTzlyS2RJaGcyUUNRcy9LSGN5c1FDOGx3bmE0ZTkxdDQrVGls?=
 =?utf-8?B?S1lkUTN1Z1dBb0E1S3ByMUtoSzJTblZSemt0ZGhqbjdMTFVIRHlkcmg5Y1Rm?=
 =?utf-8?B?MlVKZE8wVVlic2JxTVhyWDFTWmRtRy83VStsSnI3YmlOTXBob3BaMEVZb0g0?=
 =?utf-8?B?cStXRG8vTlFrdUwwUGFoWkhldDB6dnpsOUVxLy9oZUhFQjFtbUR2eTgram9R?=
 =?utf-8?B?VFlXZnFmSjA2NEJKVUxON3FCaWV1eERyd0w4S3pZRVpHUHp0VGd1M0gxUFA3?=
 =?utf-8?B?SENIZlFvME1oZWFTczNwWitEUllXbHltZXJIRG5tcXVidDlMOVplMmpTWmtE?=
 =?utf-8?B?S2ZxdE9BRjVPamdLVW13OEo4YjhxWG1oMHhhOEdlYUpvL0VWdS9BRFBZVklT?=
 =?utf-8?B?bnEvVkdhK3AzWGtsa05pMElqYmVtU3RVNHJ5L0VVcXpvWU9MUVJpL1B5WUEx?=
 =?utf-8?B?eGNoWCt5R0J4YU12N0tMWGVZVTc5RnhSVThYcStkVE9GY2M2SzVqY3FhQ2F2?=
 =?utf-8?B?bndoN2w5UzNYMnh5WlBGVmpVQUZ4VGZQN0Y2VkxESFFVSW1rcHpobnpReVlH?=
 =?utf-8?B?SHJORUlGUDJMWTZhaWtwVEVodTkvQnRYWFZNNTlxTWRkaGRFMXVGcWdiWVFS?=
 =?utf-8?B?bFZuSGhwcU1qTE1sT3VpWXI2Uit2d3prV0gyQVRjS0ZmSGVVSURQTmNieFlR?=
 =?utf-8?B?OHcrTUVoUnA5NFZ5a1k2MjRZNWtJVG1LRjBtaGZSTUQwNlM5NzdjNzJCT3g0?=
 =?utf-8?B?Z1g5ZGpic1hSNmVQaWhTK0xmd05zUGJBMitQZmJ1Nm51b3BFVnZYM0pSUTlL?=
 =?utf-8?B?emJ3cGo3OG9Ta0ZpRVhLYW4vaDU1Sno1TCticGNwNXlZZ1h3UENDY0lBMm9L?=
 =?utf-8?B?dEdmK2l5b0JjSUZuY2tRSHg5Y0ZBWVUxQS9PbzREY0d6b2ZYVGdlVWJkZi9R?=
 =?utf-8?B?WE1Rd2FGdytkS2NNYXNueTZZbnhESHhSYjY5VzkzS1haanVzU2d1V1BkSjly?=
 =?utf-8?B?bVlhbFBjRTV4L0ZkYTZsV3Q2VGM1a05CY2tLd2pEbFVDalZjS2JlRFYwSjlR?=
 =?utf-8?B?WktLMGsxQ2F2SHZJL0NEQUozLzg5S2xUMW5KWTZKRU00emNlVHFhMDE2RmJs?=
 =?utf-8?B?bWs0c1ovSStiMytlWVdvcStsRno4Wm9FQy8zU1c1UnlSS3Y5RitvbkR4bmNt?=
 =?utf-8?B?bnUyRWFZbnVqNWNNc1lPOVE3aFQvNUpRQ2JYeXhmK1ZUS0pRYlBqc1drTTZv?=
 =?utf-8?B?VGsrVU1vOEtuYlRXdjNlUXErdzFNM1NIcUdRcGEvb2RBV3dGYXRLa28rYUxw?=
 =?utf-8?B?SklvdVU0Yzh6YUlJbThiM3Vnb0xwcFdpUkNvN01XbGdyalRnTVJUTmNOTmVF?=
 =?utf-8?B?RVl1N1B4MWw2Y0RkNDhvTDkzRkJPbVc5Yi9JcUNVZDVQS0txck1VdEEzY1Y1?=
 =?utf-8?B?M3gzZkdVNVp0elFteXlUdC9vWVdZUXB3VnBlQUNiSldQQmhDcWU5RjN3Y2Jn?=
 =?utf-8?Q?mccwaVnSN57b/GAELGtfja2+4JBLZnTYuBgUwdx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30254615-3f64-4439-588c-08d931c2bbe2
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2021 19:04:29.9964
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VVPQ/p0UVb1AeqgcLHVAITRypeKDYUntKHCCF4bfAAukaYF9t9liGJDPUXhFzH4mAqaRPAp34uyxUUdFufhhDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5410
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2021-06-16 9:16 p.m., Pu Lehui wrote:
> GCC reports the following warning with W=1:
> 
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13:
> warning:
>  variable ‘dc’ set but not used [-Wunused-but-set-variable]
>     70 |  struct dc *dc = NULL;
>        |             ^~
> 
> This variable is not used in function, this commit remove it to
> fix the warning.
> 
> Signed-off-by: Pu Lehui <pulehui@huawei.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> index f7c77ae0d965..70a554f1e725 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> @@ -67,14 +67,12 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
>  	struct dc_link *link = NULL;
>  	struct psr_config psr_config = {0};
>  	struct psr_context psr_context = {0};
> -	struct dc *dc = NULL;
>  	bool ret = false;
>  
>  	if (stream == NULL)
>  		return false;
>  
>  	link = stream->link;
> -	dc = link->ctx->dc;
>  
>  	psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
>  
>