Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <d6c939f27ee67dda21562e4eb1573e6180ecef1c.camel@perches.com>
Subject: Re: Re: [PATCH] scsi: ufs: Add indent for code alignment
From:   Joe Perches <joe@perches.com>
To:     keosung.park@samsung.com, ALIM AKHTAR <alim.akhtar@samsung.com>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "satyat@google.com" <satyat@google.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <2038148563.21623893584364.JavaMail.epsvc@epcpadp4>
References: <e0950e65c5e7f8f0db132cfd22bdd24ee27c63e7.camel@perches.com>
         <1891546521.01623299401994.JavaMail.epsvc@epcpadp3>
         <CGME20210610040731epcms2p7533bc62d13b82a0e86590f30ac4b6c30@epcms2p1>
         <2038148563.21623893584364.JavaMail.epsvc@epcpadp4>
Content-Type: text/plain; charset="ISO-8859-1"
MIME-Version: 1.0
Date:   Wed, 16 Jun 2021 20:35:26 -0700
User-Agent: Evolution 3.40.0-1 
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 2021-06-17 at 10:28 +0900, Keoseong Park wrote:
> > On Thu, 2021-06-10 at 13:07 +0900, Keoseong Park wrote:
> > > Add indentation to return statement.
> > []
> > > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> > []
> > > @@ -903,7 +903,7 @@ static inline bool
> > > ufshcd_is_intr_aggr_allowed(struct ufs_hba *hba)
> > > ?	else
> > > ?		return false;
> > > ?#else
> > > -return true;
> > > +	return true;
> > > ?#endif
> > > ?}
> > > ?
> > 
> > Perhaps a little refactoring instead:
> > ---
> > drivers/scsi/ufs/ufshcd.h | 12 ++++--------
> > 1 file changed, 4 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> > index c98d540ac044d..ed89839476b3b 100644
> > --- a/drivers/scsi/ufs/ufshcd.h
> > +++ b/drivers/scsi/ufs/ufshcd.h
> > @@ -894,15 +894,11 @@ static inline bool
> > ufshcd_is_rpm_autosuspend_allowed(struct ufs_hba *hba)
> > static inline bool ufshcd_is_intr_aggr_allowed(struct ufs_hba *hba)
> > {
> > /* DWC UFS Core has the Interrupt aggregation feature but is not
> > detectable*/
> > -#ifndef CONFIG_SCSI_UFS_DWC
> > -	if ((hba->caps & UFSHCD_CAP_INTR_AGGR) &&
> > -	    !(hba->quirks & UFSHCD_QUIRK_BROKEN_INTR_AGGR))
> > +	if (IS_ENABLED(CONFIG_SCSI_UFS_DWC))
> > 		return true;
> > -	else
> > -		return false;
> > -#else
> > -return true;
> > -#endif
> > +
> > +	return (hba->caps & UFSHCD_CAP_INTR_AGGR) &&
> > +		!(hba->quirks & UFSHCD_QUIRK_BROKEN_INTR_AGGR);
> > }
> > 
> > static inline bool ufshcd_can_aggressive_pc(struct ufs_hba *hba)
> > 
> 
> Hello Joe,
> Thanks for your advice.
> As you mentioned, refactoring looks good.
> However, since the content does not match the title, can I submit a
> patch with a new title?

Yes of course.