Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Oleksandr Mazur <oleksandr.mazur@plvision.eu>
To:     "jiri@nvidia.com" <jiri@nvidia.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 00/11] Marvell Prestera driver implementation of
 devlink functionality.
Thread-Topic: [PATCH net-next 00/11] Marvell Prestera driver implementation of
 devlink functionality.
Thread-Index: AQHXXUJjufes4y4eUEeZyWSkshehZ6sYf7W4
Date:   Thu, 17 Jun 2021 17:30:07 +0000
Message-ID: <AM0P190MB0738F58BF9FFE2ED8073FA84E40E9@AM0P190MB0738.EURP190.PROD.OUTLOOK.COM>
References: <20210609151602.29004-1-oleksandr.mazur@plvision.eu>
In-Reply-To: <20210609151602.29004-1-oleksandr.mazur@plvision.eu>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?uvDzsn0xpRCST6TsYqfT5XVa90iV5ENsopDNvgw7Ui3rgWcajbMHd/uPZp?=
 =?iso-8859-1?Q?liCFgJKYN+DUwLFXmiwhXk4kwAMzyTwBJrcplkD5Eot2LPlwP4Dq7lrsDl?=
 =?iso-8859-1?Q?sUFp9bs5Uf3/4CKk2IoOTaOrYCT0+mYFSHdZtke+XauImhpBCF55pArN/O?=
 =?iso-8859-1?Q?tma8SDSyuO23fOI3+T5ATQKigMnRNJMP5GsHo3vTwqRRdLHa22qumtwA34?=
 =?iso-8859-1?Q?12Mt2LNAEeL1j6GwXv3LCWpbSe2/c65RqcT3PqhZhKZrkwwPTCt7GttAbo?=
 =?iso-8859-1?Q?zu8LAnj3yIsHKOdOMc4JR7HW4D/boCnWFCGc4Ugunt1MrcHlsqdokFF6y+?=
 =?iso-8859-1?Q?8VMJkt6rIK0jtqtytIXWU+KgOBpsNuxOWu4K1+yUzHytA2NUWFN2Hxk5aF?=
 =?iso-8859-1?Q?kAcxdLzYi+66EbmJEPTrGv+7o+0LeDf0jByAT879/wvwAd7DTh8z9OEGlr?=
 =?iso-8859-1?Q?tz5vMiQMDPvg/vhd/66PpQ4od6GYOuj+GP4ZhK/eGqJitka3/2FNM+jFyg?=
 =?iso-8859-1?Q?looNhwVVjfBjDBM0pCCOIUfubusDqyVPDk4BonubOxfO5bPMCAaOrdKHe9?=
 =?iso-8859-1?Q?sPmUDJ0IzfqQCmKPkT+u5LqWFku40XrjTB3K3YkwJ8MDL9vJNKCZhsICPt?=
 =?iso-8859-1?Q?XKo+ruaTGvED9cgbkaqoLLon0jJwiLZpskhfotdxQjMyk+Q1kDnhitFg20?=
 =?iso-8859-1?Q?WU99yvSAW6wlIzTUfwYWB1A6DqeM2gJOShmoV5sKAvVtK6+lnEttmoTpe1?=
 =?iso-8859-1?Q?nBP/TVunb7Oqd8nKDdiArha6vx75nocXBv4t+8LEulkoyL5fwOp54/oqmr?=
 =?iso-8859-1?Q?yuSnH7IpnG2gklQtsGUYTGIceJf1IPA8dfkE6ZtOW2pka2GmuqTrNhzN8t?=
 =?iso-8859-1?Q?YvgXde84Oj6gfW37XrcprHMV/qgFpx3qMbQA7stgWXvo4h1X7JYUElO8UW?=
 =?iso-8859-1?Q?zH11XPr9o8pd8MADz4Z4MohGyhu07pa72Vwm2gvEQDu34ZanB0dgM+vUOM?=
 =?iso-8859-1?Q?/YmCey7pqcHfpmpVL/S4IQgrhNWNG9DqBlHzerC4rPqGsyL3fPI+GG7mpq?=
 =?iso-8859-1?Q?jQCnCjsK06xz8bSTLraikWcmJKFcvLuSLb/YjQ0tgE4Do2Hk17nm2sb2KF?=
 =?iso-8859-1?Q?6yzjbe7AKPrzpF1CXYa/Y7+nDAuvmQrCDx7F29gFX6AsBkTYKA3m9RFA6G?=
 =?iso-8859-1?Q?PIzsrvfa3EhjDg+WeEKKH1RXNkI1e0kuCtecHckyA5TcXschC2dpB3yhYY?=
 =?iso-8859-1?Q?WulsAGMYgz5ZrGWdXJICdJtJNQZaFDMI77os6PXA4hEOCfK9E47kFcKq1q?=
 =?iso-8859-1?Q?JzJ1qOfUW/dgUaku3lRImrIMk9qbI8/GwD6u4CLj7/FgrWA=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0P190MB0738.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 62802885-d987-4f67-2800-08d931b58cd8
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2021 17:30:07.0199
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sxJ7U48zS1tGvBDMzp3W1x0BrnP4qc+IhIBg854wSzxuAG32dhnxebthy9UkxOwyJu4a7frJTcw/s8uvhYIvPOyN70VNLA53ngh4W8nuU+I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0P190MB0723
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Prestera Switchdev driver implements a set of devlink-based features,=0A=
> that include both debug functionality (traps with trap statistics), as we=
ll=0A=
> as functional rate limiter that is based on the devlink kernel API (inter=
faces).=0A=
=0A=
> The core prestera-devlink functionality is implemented in the prestera_de=
vlink.c.=0A=
=0A=
> The patch series also extends the existing devlink kernel API with a list=
 of core=0A=
> features:=0A=
> =A0- devlink: add API for both publish/unpublish port parameters.=0A=
> =A0- devlink: add port parameters-specific ops, as current design makes i=
t impossible=0A=
>  =A0 to register one parameter for multiple ports, and effectively distin=
guish for=0A=
> =A0 what port parameter_op is called.=0A=
=0A=
As we discussed the storm control (BUM) done via devlink port params topic,=
 and agreed that it shouldn't be done using the devlink API itself, there's=
 an open question i'd like to address: the patch series included, for what =
i think, list of needed and benefitial changes, and those are the following=
 patches:=0A=
=0A=
> Oleksandr Mazur (2):=0A=
...=0A=
>  net: core: devlink: add port_params_ops for devlink port parameters alte=
ring=0A=
>  drivers: net: netdevsim: add devlink port params usage=0A=
 =0A=
> Sudarsana Reddy Kalluru (1):=0A=
>  net: core: devlink: add apis to publish/unpublish port params=0A=
=0A=
So, should i create a new patch series that would include all of them?=0A=
=0A=
Because in that case the series itself would lack an actual HW usage of it.=
 The only usage would be limited to the netdevsim driver.=