Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] serial: amba-pl011: add RS485 support
To:     Jiri Slaby <jirislaby@kernel.org>, gregkh@linuxfoundation.org
Cc:     linux@armlinux.org.uk, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210610135004.7585-1-LinoSanfilippo@gmx.de>
 <5f00ff43-9287-4027-7d80-474da957703c@kernel.org>
From:   Lino Sanfilippo <LinoSanfilippo@gmx.de>
Message-ID: <7c0ac56d-58da-5e8a-b6be-44bafb183443@gmx.de>
Date:   Thu, 17 Jun 2021 19:44:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <5f00ff43-9287-4027-7d80-474da957703c@kernel.org>
Content-Type: text/plain; charset=iso-8859-2
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


Hi,

On 16.06.21 at 08:18, Jiri Slaby wrote:
=A0=A0=A0=A0=A0=A0=A0 mdelay(port->rs485.delay_rts_before_send);
>
> This is up to 1 second delay with interrupts disabled. Definitely not ni=
ce. 8250 clamps this to 100 ms at least, why did you choose 1000 ms?
>

AFAICS the 8250 driver does not clamp values read from the device tree pro=
perty "rs485-rts-delay"
(set by uart_get_rs485_mode()). Is this on purpose?

Regards,
Lino